Feature: .NET Core / .NET 5 compatibility #29
+344
−132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any news on this topic? |
Contributor
Author
|
Thanks for your work on a .NET Core / 5 version! Shouldn't it become a fork of this project, seeing that there haven't been updates for quite a while now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been a few years. Hi again!
This PR adds compatibility with .NET Core and the newly released .NET 5. It also moves the main
csprojfile to an SDK-style project. A .NET 4.5.1 build output is still created. I also added a .NET 5 sample for a proof of concept that uses the latest version of MahApps.Metro (2.3.4 as of this writing).All that would need to be done after merging this is bumping the version (in the
.csprojnow) and updating the NuGet.One way to easy-mode make a NuGet package is to right click the csproj -> Properties -> Package -> check the 'Generate NuGet package on build' checkbox. Then it'll take care of a bunch of annoying details for you.
@AleksandarDev Any chance we could have an updated NuGet when/if this is merged? Thanks! :)