Skip to content

Conversation

@avik-pal
Copy link
Collaborator

@avik-pal avik-pal commented Dec 2, 2025

This will likely fix the issue with tt that @giordano reported some time back.

@avik-pal avik-pal requested a review from wsmoses December 2, 2025 18:35
Copy link
Member

@wsmoses wsmoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GleasonK i vaguely recall there being an existing stablehlo pass for this?

@avik-pal avik-pal force-pushed the ap/while_loop_all_values branch from b7f68b1 to fed98ee Compare December 2, 2025 18:38
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EnzymeJAX Benchmarks

Benchmark suite Current: 90beba7 Previous: f603104 Ratio
scatter_sum / JaX / cpu / Primal 0.0000042210789993987415 s 0.000004260189699562034 s 0.99
scatter_sum / JaXPipe / cpu / Primal 0.000004273433900380042 s 0.000004406429699884029 s 0.97
scatter_sum / JaX / tpu / Primal 0.0001627930903006 s 0.0001248841227003 s 1.30
scatter_sum / JaXPipe / tpu / Primal 0.0001470225415003 s 0.0001351668211995 s 1.09

This comment was automatically generated by workflow using github-action-benchmark.

@Pangoraw
Copy link
Collaborator

Pangoraw commented Dec 3, 2025

@avik-pal avik-pal force-pushed the ap/while_loop_all_values branch from 49f1f69 to 90beba7 Compare December 3, 2025 14:24
@GleasonK
Copy link
Contributor

GleasonK commented Dec 3, 2025

We have:

An improvement to the prepareExplicitCapture for whileop would be to only sink smaller constants or single-use constants into the while body, converting larger shared constants into arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants