feat: early fail if not correct region #1008
Draft
+54
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmoses
reviewed
Mar 23, 2025
| function create_operation(args...; kwargs...) | ||
| res = create_operation_common(args...; kwargs...) | ||
| res = create_operation_common_with_checks(args...; kwargs...) | ||
| if _has_block() |
There was a problem hiding this comment.
technically speaking the actual issue here is actually on like 349, where we're accidentally creating a stablehlo.constant operation, and pushing it into a module. It's probably better to figure out we're creating it at the wrong place, rather than figure out during the use stage that we're using an operation which is itself in the wrong place
There was a problem hiding this comment.
We had an older issue where a concreteRNG state wasn't being reset, so the region was completely different. We can't capture that without adding checks here
|
currently low priority, will deal with this later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.