feat: move transposes up (and then down) #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
forgot to add broadcastindim is reshape to td, though I will merge it with the canon today anyways |
avik-pal
force-pushed
the
ap/opts_new
branch
4 times, most recently
from
d409a35 to
2297685
Compare
|
i might have enabled conflicting optimizations |
avik-pal
force-pushed
the
ap/opts_new
branch
3 times, most recently
from
632e1ca to
7518034
Compare
avik-pal
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
avik-pal
force-pushed
the
ap/opts_new
branch
2 times, most recently
from
ad689d8 to
169b182
Compare
|
failures due to EnzymeAD/Enzyme-JAX#586 |
giordano
force-pushed
the
ap/opts_new
branch
2 times, most recently
from
55d215b to
38e713d
Compare
|
This is not working in GB-25: PRONTOLab/GB-25#128 (comment) |
|
Let me try and patch it |
|
and I broke more stuff... |
|
Also @wsmoses one of the 5 commented out reshape passes are probably broken https://github.com/EnzymeAD/Reactant.jl/actions/runs/14195378107/job/39769233267?pr=1099#step:10:576 |
|
actually need to check which one is broken, that is not the one I activated in the last commit |
|
Sp the problem in the GB repo is not fixed yet. The thing which ends up happening is that the input buffers can now be aliased and we need to be careful while donating it |
avik-pal
force-pushed
the
ap/opts_new
branch
4 times, most recently
from
dd8a43b to
1e01733
Compare
feat: try collapsing the ops again fix: syntax feat: bump jll fix: print for debugging fix: unary transpose fix: try fixing fix: conflicting passes fix: conflicting passes feat: newer opts fix: reshape pad fix: avoid transpose_reduce_window for now Update to Reactant_jll v0.0.116 fix: add some aliasing checks feat: enable more passes fix: disable some passes again fix: types fix: rollback some changes fix: rollback more passes feat: store if an arg is donated fix: mark donated fix: remove broadcast_in_dim_is_reshape for now fix: reshape_pad is also broken fix: concat is busted not pad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.