Skip to content

feat: add debug option for always sharding #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add debug option for always sharding #1134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/Types.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ function get_padding(x)
return ntuple(Returns(0), ndims(x))
end

const DEBUG_ENSURE_ALWAYS_SHARDED = Ref(false)

# Traced Types

## MissingTracedValue -- defined in ReactantCore
Expand Down Expand Up @@ -95,6 +97,9 @@ mutable struct ConcretePJRTNumber{T,D,S<:Sharding.ShardInfo} <: AbstractConcrete
function ConcretePJRTNumber{T,D,S}(
data::NTuple{D,XLA.PJRT.AsyncBuffer}, sharding::S
) where {T,D,S}
if DEBUG_ENSURE_ALWAYS_SHARDED[]
@assert Sharding.is_sharded(sharding)
end
return new{T,D,S}(data, sharding, false)
end
end
Expand Down Expand Up @@ -148,6 +153,9 @@ mutable struct ConcretePJRTArray{T,N,D,S<:Sharding.ShardInfo} <: AbstractConcret
function ConcretePJRTArray{T,N,D,S}(
data::NTuple{D,XLA.PJRT.AsyncBuffer}, shape::NTuple{N,Int}, sharding::S
) where {T,N,D,S}
if DEBUG_ENSURE_ALWAYS_SHARDED[]
@assert Sharding.is_sharded(sharding)
end
return new{T,N,D,S}(data, shape, sharding, false)
end
end
Expand Down Expand Up @@ -251,6 +259,9 @@ mutable struct ConcreteIFRTNumber{T,S<:Sharding.ShardInfo} <: AbstractConcreteNu
donated::Bool

function ConcreteIFRTNumber{T,S}(data::XLA.IFRT.AsyncArray, sharding::S) where {T,S}
if DEBUG_ENSURE_ALWAYS_SHARDED[]
@assert Sharding.is_sharded(sharding)
end
return new{T,S}(data, sharding, false)
end
end
Expand Down Expand Up @@ -301,6 +312,9 @@ mutable struct ConcreteIFRTArray{
sharding::S,
padding::Union{Nothing,NTuple{N,Int}}=nothing,
) where {T,N,S}
if DEBUG_ENSURE_ALWAYS_SHARDED[]
@assert Sharding.is_sharded(sharding)
end
return new{T,N,S,typeof(padding)}(data, shape, sharding, false, padding)
end
end
Expand Down
Loading