change to dialect generator#691
Open
glou-nes wants to merge 29 commits into
Open
Conversation
Pangoraw
reviewed
Feb 5, 2025
mofeing
reviewed
Feb 6, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #691 +/- ##
===========================================
+ Coverage 21.66% 38.03% +16.36%
===========================================
Files 46 85 +39
Lines 8048 15896 +7848
===========================================
+ Hits 1744 6046 +4302
- Misses 6304 9850 +3546 ☔ View full report in Codecov by Sentry. |
Pangoraw
reviewed
Feb 12, 2025
Collaborator
There was a problem hiding this comment.
FYI, there are still a few files with changes in permissions.
Contributor
Author
There was a problem hiding this comment.
thx, each time I format I have to change them. It seems some are 644 and some are 755. Now, all dialects files are 755. I don't know how CI set the permission.
Collaborator
There was a problem hiding this comment.
oh right that's probably from
Reactant.jl/.github/workflows/regenerate-mlir-bindings.yml
Lines 43 to 47 in 95f6074
Pangoraw
reviewed
Feb 13, 2025
Contributor
Author
|
@wsmoses this seems to be alright! CI failure seems unrelated. |
wsmoses
approved these changes
Feb 13, 2025
Member
|
https://github.com/EnzymeAD/Reactant.jl/actions/runs/13371624570/job/37341205434?pr=691#step:7:168 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rebase #660 & #447. @mofeing I messed up #660 so I open a new PR.
Several modifications:
result_toresultresult_layouts=nothing::Union{Attribute, Nothing}doesn't constraintresult_layoutsso change to :result_layouts::Union{Attribute, Nothing} =nothingEnumAttr: using Attr parsing (MLIR doesn't expose methods in C to easily construct arbitrary attribute) and discriminant.conv