-
Notifications
You must be signed in to change notification settings - Fork 12
fix(hub-common): hide incomplete download format configuration ui and prevent saving discussion settings on enterprise #2102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
… prevent saving discussion settings on enterprise (#2097)
🦋 Changeset detectedLatest commit: 62a8022 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and you just confirmed in a side chat that you're doing jasmine -> vitest here to catch up.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2102 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 811 853 +42
Lines 15763 13394 -2369
Branches 3161 3483 +322
===========================================
- Hits 15763 13394 -2369 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
There hasn't been any activity on this pull request in the past 3 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want this PR to never become stale, please apply the "Draft" label. |
Description:
Cherry pick of fix(hub-common): hide incomplete download format configuration ui on enterprise #2097
Either ran
npm run changesetor this change does not require a release.These changes have been verified by QA using a
?uiVersionthat includes a PR-Preview of this branch and thev_reqlabel has been applied to the issue.OD-UI E2E tests pass against these changes using a
?uiVersionthat includes a PR-Preview of this branch