Skip to content

Conversation

@sonofflynn89
Copy link
Contributor

@sonofflynn89 sonofflynn89 commented Oct 27, 2025

  1. Description:
    Cherry pick of fix(hub-common): hide incomplete download format configuration ui on enterprise #2097

  2. Either ran npm run changeset or this change does not require a release.

  3. These changes have been verified by QA using a ?uiVersion that includes a PR-Preview of this branch and the v_req label has been applied to the issue.

  4. OD-UI E2E tests pass against these changes using a ?uiVersion that includes a PR-Preview of this branch

… prevent saving discussion settings on enterprise (#2097)
@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2025

🦋 Changeset detected

Latest commit: 62a8022

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@esri/hub-common Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@knbhagat knbhagat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@abp6318 abp6318 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and you just confirmed in a side chat that you're doing jasmine -> vitest here to catch up.

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (cf25b6d) to head (4fc06b2).
⚠️ Report is 28 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##            master     #2102     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          811       853     +42     
  Lines        15763     13394   -2369     
  Branches      3161      3483    +322     
===========================================
- Hits         15763     13394   -2369     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

There hasn't been any activity on this pull request in the past 3 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want this PR to never become stale, please apply the "Draft" label.

@github-actions github-actions bot added the Stale Stale issue - update or it will be closed label Nov 4, 2025
@sonofflynn89 sonofflynn89 removed the Stale Stale issue - update or it will be closed label Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants