Skip to content

Fix format parsing in ban messages #5722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Fix format parsing in ban messages #5722

merged 1 commit into from
Mar 4, 2024

Conversation

Evidentsinger14
Copy link
Member

Information

This PR fixes #5721.

Details

  • Most recent Paper version (1.XX.Y, git-Paper-BUILD)
  • CraftBukkit/Spigot/Paper 1.12.2
  • CraftBukkit 1.8.8

Demonstration:

image

Additional Information
This PR only fixes the problems mentioned in the linked issue, however while debugging this I also noticed that /tempban <player> <duration> <reason> is not converting color codes to MiniMessage as seen below.
image
image
Can fix in this PR, or create a new one later if this PR gets merged.

@Evidentsinger14 Evidentsinger14 changed the title fix parsing on player screen Fix MM tags being parsed in ban messages Mar 3, 2024
@JRoy JRoy changed the title Fix MM tags being parsed in ban messages Fix format parsing in ban messages Mar 4, 2024
@JRoy JRoy merged commit a4ac720 into EssentialsX:2.x Mar 4, 2024
1 check passed
@Evidentsinger14 Evidentsinger14 deleted the fix/5721 branch March 4, 2024 21:42
HarvelsX pushed a commit to HarvelsX/Essentials that referenced this pull request Jun 2, 2024
Starmism pushed a commit to valence-smp/Essentials that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The text of the ban message is buggy
2 participants