Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.21.4 #78

Merged
merged 14 commits into from
Feb 19, 2025
Merged

Update to 1.21.4 #78

merged 14 commits into from
Feb 19, 2025

Conversation

msburgess3200
Copy link
Collaborator

Removed deprecated functions.
Updated API to 1.21.4

@msburgess3200
Copy link
Collaborator Author

I also added a debug in the config.yml to output to the minecraft console. I have plans to include MySQL and SQLite database types instead of serial.

Copy link
Owner

@EtienneDx EtienneDx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for picking this up. Feel free to add a redirect in the readme to your own repo, or to keep sharing here. I can also add you directly to the repo so you can create releases here. I'll probably stay available for reviews but it's unlikely that I'll dive back in.

src/me/EtienneDx/RealEstate/Config.java Outdated Show resolved Hide resolved
src/me/EtienneDx/RealEstate/RealEstate.java Outdated Show resolved Hide resolved
src/me/EtienneDx/RealEstate/Transactions/Transaction.java Outdated Show resolved Hide resolved
@EtienneDx EtienneDx requested a review from Copilot February 10, 2025 20:18

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 10 changed files in this pull request and generated no comments.

Files not reviewed (5)
  • pom.xml: Language not supported
  • src/me/EtienneDx/RealEstate/ClaimPermissionListener.java: Evaluated as low risk
  • src/me/EtienneDx/RealEstate/Config.java: Evaluated as low risk
  • src/me/EtienneDx/RealEstate/RealEstate.java: Evaluated as low risk
  • src/me/EtienneDx/RealEstate/Transactions/ClaimRent.java: Evaluated as low risk
Comments suppressed due to low confidence (1)

src/me/EtienneDx/RealEstate/Transactions/ClaimSell.java:42

  • The method getSide(Side.FRONT) may not be supported in all versions of the API. Ensure compatibility or provide a fallback.
s.getSide(Side.FRONT).setLine(0, Messages.getMessage(RealEstate.instance.config.cfgSignsHeader, false));
@msburgess3200
Copy link
Collaborator Author

No worries. I'll clean up the code. I wanted to at least offer a small portion to give back to the plugin I used many years ago. My minecraft server is getting larger and thought I would attempt an update. I mainly code PHP, and C#. My first time in Java. lol.

@msburgess3200
Copy link
Collaborator Author

Thanks a lot for picking this up. Feel free to add a redirect in the readme to your own repo, or to keep sharing here. I can also add you directly to the repo so you can create releases here. I'll probably stay available for reviews but it's unlikely that I'll dive back in.

I would never steal your code. I don't think it'd be fair to do that. If you want to add me to your repo that'd be great, or I can do PRs. Either way works for me. :)

@msburgess3200
Copy link
Collaborator Author

msburgess3200 commented Feb 11, 2025

Also fixed issue #77 and #75 in this "patch"

@EtienneDx
Copy link
Owner

I've added you to the repo, feel free to go the extra step and create a release with the jar and changelog!

Please see change log.
@msburgess3200
Copy link
Collaborator Author

I think you'll like the improvements. Have a look at the new commit.

Copy link
Owner

@EtienneDx EtienneDx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the changes, I left a couple comments. One thing, it'd be great to run a formatter on the codebase to be consistent on spaces/tabs (or at least on the modified files).

src/me/EtienneDx/RealEstate/REListener.java Outdated Show resolved Hide resolved
src/me/EtienneDx/RealEstate/RealEstate.java Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@msburgess3200
Copy link
Collaborator Author

msburgess3200 commented Feb 15, 2025

Can you add me on Discord? I have a couple of questions:
SkyWalker3200 or shoot me an email: [email protected]

Include a static file to reduce plugin load time.
Moved Language resource files to better manage community translations.
Per request
Introduces Javadoc, WorldGuard, and Towny
Included bStats
Updated language files
Copy link
Owner

@EtienneDx EtienneDx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge. I think maybe we could improve a little the code on the transactionStore by having an ITransactionStore and a TransactionStoreFile, TransactionStoreMysql etc but that's not important. Let's merge this now beofer adding new commits since it's becoming a large chunk to review :)

@msburgess3200 msburgess3200 merged commit ef23ffe into EtienneDx:master Feb 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants