fix(headers) tabs are allowed, and whitespace must be trimmed

EvandroLG · Feb 19, 2023 · bcc4848 · bcc4848
1 parent b8fe100
commit bcc4848
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/spec/unit/request_spec.lua b/spec/unit/request_spec.lua
@@ -59,7 +59,7 @@ describe('require', function()
 
   test('headers', function()
     local request = getInstance(
-      { 'GET /Makefile?a=b&c=d&e=1&e=2 HTTP/1.1', 'a: A', 'b: B', 'c: X', 'c: Y', '', 'C=3', '' }
+      { 'GET /Makefile?a=b&c=d&e=1&e=2 HTTP/1.1', 'a:A', 'b: \t  B \t  ', 'c: X', 'c: Y', '', 'C=3', '' }
     )
 
     assert.are.same(

diff --git a/src/pegasus/request.lua b/src/pegasus/request.lua
@@ -34,7 +34,7 @@ Request.PATTERN_PROTOCOL = '(HTTP%/%d%.%d)'
 Request.PATTERN_REQUEST = (Request.PATTERN_METHOD ..
 Request.PATTERN_PATH ..Request.PATTERN_PROTOCOL)
 Request.PATTERN_QUERY_STRING = '([^=]*)=([^&]*)&?'
-Request.PATTERN_HEADER = '([%w-]+): ([%w %p]+=?)'
+Request.PATTERN_HEADER = '([%w-]+):[ \t]*([%w \t%p]*)'
 
 function Request:new(port, client, server)
   local obj = {}
@@ -142,6 +142,7 @@ function Request:headers()
     local key, value = string.match(data, Request.PATTERN_HEADER)
 
     if key and value then
+      value = value:gsub("%s+$", "") -- trim trailing whitespace
       local v = headers[key]
       if not v then
         headers[key] = value