Add make twitter authenticated requests #101
Conversation
🦋 Changeset detectedLatest commit: 6664b15 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Adebesin-Cell
left a comment
Adebesin-Cell
left a comment
There was a problem hiding this comment.
The code for Twitter looks great! Could you kindly remove any unrelated changes that aren’t directly related to configuring Twitter?
Also, please expose the necessary utility for making requests in index.ts, as it serves as the entry point of the package.
export * from "./lib/wiki-score";
export * from "./lib/check-deep-equal";
export * from "./lib/check-wiki-validity";
export * from "./data/constants";
export * from "./schema";| // =============================== | ||
| export function isEventWikiValid(wiki: any): boolean { | ||
| if (wiki.tags.some((tag: any) => tag.id === "Events")) { | ||
| export function isEventWikiValid(wiki: { |
There was a problem hiding this comment.
Why these changes? Are they related to this PR?
There was a problem hiding this comment.
I got a failed build due to any usage
| "@changesets/cli": "^2.24.0", | ||
| "@types/node": "^22.7.4", | ||
| "changeset": "^0.2.6", | ||
| "husky": "^9.1.7", |
There was a problem hiding this comment.
Why are we introducing husky?
There was a problem hiding this comment.
I was getting a failed build because it was not catching some errors here. So I setup a pre-commit hook to help prevent future occurrences
There was a problem hiding this comment.
I think we could add in another PR. 👍 Keeps the PR lean
What kind of change does this PR introduce? Add the sendTwitterApiRequest
What is the current behavior? we currently don't have a sendTwitterApiRequest function
What is the new behavior (if this is a feature change)? adds the sendTwitterApiRequest feature