Develop

[vnoves]

Summary by CodeRabbit

Release Notes

• Bug Fixes & Improvements

  • Enhanced path validation with support for multiple file paths in configuration processing.
  • Improved normal vector distribution in glTF exports for better geometry accuracy.

• UI Improvements

  • Optimized error window layout with centered button alignment and refined spacing.

• Documentation

  • Added Sponsors section to README.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Six files updated: DLL loading paths shifted from CommonApplicationData to ApplicationData for Revit 2025/2026; RevitIniReader refactored to handle multi-path strings with validation and normalization; normal distribution logic modified to emit duplicated normals; button alignment adjusted in error window UI; README sponsors section added.

Changes

Cohort / File(s)	Summary
DLL path adjustments Common_glTF_Exporter/Export/Draco.cs, Common_glTF_Exporter/Export/MeshOpt.cs	Changed folder constant from Environment.SpecialFolder.CommonApplicationData to Environment.SpecialFolder.ApplicationData for REVIT2025/REVIT2026 blocks; MeshOpt.cs also removed indentation from preprocessor directive.
Path parsing refactoring Common_glTF_Exporter/Utils/RevitIniReader.cs	Replaced single-path handling with iterative multi-path processing: splits by semicolons, validates each sub-path, skips invalid paths with logging, normalizes pipe separators to semicolons, and accumulates resolved absolute paths.
Mesh normal processing Common_glTF_Exporter/Utils/glTFExportUtils.cs	Modified OnEachFacet distribution in AddNormals to emit each transformed normal three times (via loop) instead of single addition.
UI layout adjustments Common_glTF_Exporter/Windows/ErrorWindow.xaml	Added HorizontalAlignment="Center" and Margin="0,0,0,15" to button StackPanel for centered alignment and bottom spacing.
Documentation README.md	Added Sponsors section with introductory text, badge image link, and spacing.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

• RevitIniReader.cs: Path splitting and validation logic warrants careful verification of edge cases (empty paths, invalid characters, relative path resolution).
• glTFExportUtils.cs: Confirm that triplicating normals in OnEachFacet aligns with mesh geometry expectations and doesn't create unintended visual artifacts.
• DLL path changes: Verify that ApplicationData folder is the correct and intended location for both Draco and MeshOpt DLLs in Revit 2025/2026 environments.

Possibly related issues

• Issue #130: The PR directly addresses the hard-coded DLL path problem by switching from CommonApplicationData to ApplicationData for MeshOpt.dll and DracoWrapper.dll lookup in Revit 2025/2026.

Possibly related PRs

• PR #116: Updates RevitIniReader path parsing and normalization logic (multi-path splitting, validation, folder constant changes) that directly modifies the same file and functionality.
• PR #134: Modifies the same GLTFExportUtils.AddNormals function, specifically the OnEachFacet branch to emit normals three times.
• PR #101: Adjusts conditional-compilation blocks in Draco.cs and MeshOpt.cs for REVIT2025/REVIT2026 handling and DLL lookup paths.

Poem

A rabbit hops through paths so grand,
Splitting strings across the land! 🥕
Normals dance in triplicate grace,
While DLLs find their proper place,
Buttons centered, sponsors shown—
This code's a burrow brightly sewn! ✨

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch develop

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a286d7b and ebe4d19.

📒 Files selected for processing (6)

• Common_glTF_Exporter/Export/Draco.cs (1 hunks)
• Common_glTF_Exporter/Export/MeshOpt.cs (1 hunks)
• Common_glTF_Exporter/Utils/RevitIniReader.cs (1 hunks)
• Common_glTF_Exporter/Utils/glTFExportUtils.cs (1 hunks)
• Common_glTF_Exporter/Windows/ErrorWindow.xaml (1 hunks)
• README.md (1 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}