Skip to content

cleanup project files#147

Merged
vnoves merged 1 commit intoEverseDevelopment:developfrom
wsw0108:develop
Feb 12, 2026
Merged

cleanup project files#147
vnoves merged 1 commit intoEverseDevelopment:developfrom
wsw0108:develop

Conversation

@wsw0108
Copy link

@wsw0108 wsw0108 commented Feb 11, 2026

Summary by CodeRabbit

  • Chores
    • Reorganized build configuration settings across all supported versions to improve consistency and reduce redundancy.
    • Standardized code analysis rule set references across debug and release configurations.
    • Simplified intermediate output path configuration.

@coderabbitai
Copy link

coderabbitai bot commented Feb 11, 2026

Walkthrough

Centralizes code analysis ruleset configuration across multiple Revit exporter project versions by consolidating references from version-specific or local e-verse.ruleset files to a shared ../e-verse.ruleset in the parent directory. The 2024 version's local ruleset file is removed as part of this consolidation.

Changes

Cohort / File(s) Summary
Build Configuration Updates
Revit_glTF_Exporter_2019/Revit_glTF_Exporter_2019.csproj, Revit_glTF_Exporter_2021/Revit_glTF_Exporter_2021.csproj, Revit_glTF_Exporter_2022/Revit_glTF_Exporter_2022.csproj
Updated Debug and Release configurations to reference centralized ../e-verse.ruleset instead of version-specific paths.
Build Configuration & Path Normalization
Revit_glTF_Exporter_2020/Revit_glTF_Exporter_2020.csproj
Consolidated CodeAnalysisRuleSet paths to ../e-verse.ruleset across multiple configurations and removed IntermediateOutputPath entries.
Build Configuration & Parent Reference
Revit_glTF_Exporter_2023/Revit_glTF_Exporter_2023.csproj, Revit_glTF_Exporter_2024/Revit_glTF_Exporter_2024.csproj
Updated CodeAnalysisRuleSet paths to use parent directory reference ../e-verse.ruleset.
Ruleset Consolidation
Revit_glTF_Exporter_2024/e-verse.ruleset
Removed local ruleset file containing 271 lines of analyzer rule definitions across Microsoft and StyleCop analyzers, as analysis configuration is now centralized in parent directory.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 The rulesets now dance in harmony,
From scattered paths to one shared decree,
Hop by hop, the config aligns,
A cleaner build, no more line designs,
Central rules for all to see! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'cleanup project files' accurately reflects the main change: updates to multiple .csproj files to centralize code analysis ruleset paths and remove configuration-specific paths.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments
Revit_glTF_Exporter_2020/Revit_glTF_Exporter_2020.csproj (1)

67-69: Pre-existing: REVIT2022 configuration block is missing CodeAnalysisRuleSet.

Every other configuration block in this file now has <CodeAnalysisRuleSet>..\e-verse.ruleset</CodeAnalysisRuleSet>, but the REVIT2022|AnyCPU block (Line 67-69) does not. Since this PR is standardizing ruleset references, consider adding it here too for consistency. Also, Line 68 has a typo: bin\REVIT20222\ (extra 2).

Proposed fix
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'REVIT2022|AnyCPU' ">
-    <OutputPath>bin\REVIT20222\</OutputPath>
+    <OutputPath>bin\REVIT2022\</OutputPath>
+    <CodeAnalysisRuleSet>..\e-verse.ruleset</CodeAnalysisRuleSet>
   </PropertyGroup>

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vnoves vnoves merged commit c861068 into EverseDevelopment:develop Feb 12, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants