Skip to content

Add validation for Server parameter binding #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PrzemyslawKlys merged 2 commits into from
Dec 9, 2025
Merged

Add validation for Server parameter binding #470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ac8831
Add validation for Server parameter binding
PrzemyslawKlys Nov 29, 2025
7f03c9f
Merge branch 'main' into convert-server-to-auto-property-with-validation
PrzemyslawKlys Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion DnsClientX.PowerShell/CmdletResolveDnsQuery.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,8 @@ public sealed class CmdletResolveDnsQuery : AsyncPSCmdlet {
[Alias("ServerName")]
[Parameter(Mandatory = false, ParameterSetName = "ServerName")]
[Parameter(Mandatory = false, ParameterSetName = "PatternServerName")]
public List<string> Server = new List<string>();
[ValidateNotNull]
public List<string> Server { get; set; } = new List<string>();

/// <summary>
/// <para type="description">One or more resolver endpoints in string format. Accepted: "1.1.1.1:53", "[2606:4700:4700::1111]:53", "dns.google:53", or DoH URLs like "https://dns.google/dns-query".</para>
Expand Down
16 changes: 16 additions & 0 deletions Module/Tests/ResolveDnsBinding.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
Import-Module "$PSScriptRoot/../DnsClientX.psd1" -Force

Describe 'Resolve-Dns binding' {
It 'exposes Server parameter with ServerName alias and list type' {
$cmd = Get-Command Resolve-Dns
$parameter = $cmd.Parameters['Server']

$parameter | Should -Not -BeNullOrEmpty
$parameter.Aliases | Should -Contain 'ServerName'
$parameter.ParameterType | Should -Be ([System.Collections.Generic.List[string]])
}

It 'rejects null Server values during binding' {
{ Resolve-Dns -Name 'example.com' -Server $null -ErrorAction Stop } | Should -Throw -ExceptionType ([System.Management.Automation.ParameterBindingException])
}
}
Loading