Skip to content

test: ✨ Improve assertions in ResolveFirst and ResolveSync tests #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PrzemyslawKlys merged 4 commits into from
Jan 3, 2026
Merged

test: ✨ Improve assertions in ResolveFirst and ResolveSync tests #481

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
66315c7
test: ✨ Improve assertions in `ResolveFirst` and `ResolveSync` tests
PrzemyslawKlys Jan 2, 2026
d8debb2
fix(tests): 🐛 Update `ShouldSkipEndpoint` to include UDP check
PrzemyslawKlys Jan 2, 2026
0fbfcc1
chore: 🔧 Bump version to `1.0.7` for all project files
PrzemyslawKlys Jan 2, 2026
c0794db
fix(tests): 🐛 Refactor port allocation methods for UDP and TCP
PrzemyslawKlys Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions DnsClientX.Tests/ResolveFirst.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,9 @@ public async Task ShouldWorkForA(DnsEndpoint endpoint) {
using var Client = new ClientX(endpoint);
var answer = await Client.ResolveFirst("evotec.pl", DnsRecordType.A, cancellationToken: CancellationToken.None);
Assert.True(answer != null);
Assert.True(answer.Value.Name == "evotec.pl");
Assert.True(answer.Value.Type == DnsRecordType.A);
Comment on lines 60 to 61
Copy link

Copilot AI Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The assertions on lines 60-61 lack descriptive messages while the new assertions below them have descriptive messages. For consistency with the improvements in this PR, consider adding descriptive messages to these assertions as well, such as "Expected a non-null answer" for line 60 and "Expected A record but got {answer.Value.Type}" for line 61.

Copilot uses AI. Check for mistakes.
Assert.True(!string.IsNullOrWhiteSpace(answer.Value.Name), "Expected answer name to not be empty");
Assert.True(System.Net.IPAddress.TryParse(answer.Value.Data, out var ipAddress) && ipAddress.AddressFamily == System.Net.Sockets.AddressFamily.InterNetwork, $"Expected A record data to be an IPv4 address but got '{answer.Value.Data}' (name '{answer.Value.Name}', original '{answer.Value.OriginalName}')");
}

/// <summary>
Expand Down Expand Up @@ -111,8 +112,9 @@ public void ShouldWorkForA_Sync(DnsEndpoint endpoint) {
using var Client = new ClientX(endpoint);
var answer = Client.ResolveFirstSync("evotec.pl", DnsRecordType.A, cancellationToken: CancellationToken.None);
Assert.True(answer != null);
Assert.True(answer.Value.Name == "evotec.pl");
Assert.True(answer.Value.Type == DnsRecordType.A);
Comment on lines 114 to 115
Copy link

Copilot AI Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The assertions on lines 114-115 lack descriptive messages while the new assertions below them have descriptive messages. For consistency with the improvements in this PR, consider adding descriptive messages to these assertions as well, such as "Expected a non-null answer" for line 114 and "Expected A record but got {answer.Value.Type}" for line 115.

Copilot uses AI. Check for mistakes.
Assert.True(!string.IsNullOrWhiteSpace(answer.Value.Name), "Expected answer name to not be empty");
Assert.True(System.Net.IPAddress.TryParse(answer.Value.Data, out var ipAddress) && ipAddress.AddressFamily == System.Net.Sockets.AddressFamily.InterNetwork, $"Expected A record data to be an IPv4 address but got '{answer.Value.Data}' (name '{answer.Value.Name}', original '{answer.Value.OriginalName}')");
}
}
}
9 changes: 5 additions & 4 deletions DnsClientX.Tests/ResolveSync.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,10 +298,11 @@ public void ShouldWorkForFirstSyncA(DnsEndpoint endpoint) {
if (ShouldSkipEndpoint(endpoint)) return;
using var client = new ClientX(endpoint);
var answer = client.ResolveFirstSync("evotec.pl", DnsRecordType.A, cancellationToken: CancellationToken.None);
Assert.True(answer != null);
Assert.True(answer.Value.Name == "evotec.pl");
Assert.True(answer.Value.Type == DnsRecordType.A);
Assert.True(answer.Value.Data.Length > 0);
Assert.True(answer != null, "Expected a non-null answer");
Assert.True(answer.Value.Type == DnsRecordType.A, $"Expected A record but got {answer.Value.Type}");
Assert.True(!string.IsNullOrWhiteSpace(answer.Value.Name), "Expected answer name to not be empty");
Assert.True(!string.IsNullOrWhiteSpace(answer.Value.Data), "Expected answer data to not be empty");
Assert.True(System.Net.IPAddress.TryParse(answer.Value.Data, out var ipAddress) && ipAddress.AddressFamily == System.Net.Sockets.AddressFamily.InterNetwork, $"Expected A record data to be an IPv4 address but got '{answer.Value.Data}' (name '{answer.Value.Name}', original '{answer.Value.OriginalName}')");
}

/// <summary>
Expand Down
Loading