Small improvements #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tidy `Publish-GitHubReleaseAsset` docs and exports * `Get-PowerShellAssemblyMetadata`: load target assembly first and resolve `System.Management.Automation` inside the same MetadataLoadContext (by referenced name or fallback to host path) to avoid type identity issues. * Add robust cmdlet detection (attribute FullName + fallback walking base types for `Cmdlet`/`PSCmdlet`), handle `GetTypes()` exceptions by falling back to `GetExportedTypes()`, extract aliases reliably, and return unique results. * `Docs/Publish-GitHubReleaseAsset.md`: reorganize parameter sections, move/clean up examples, remove duplicated TagTemplate/ZipPath blocks and replace some descriptions with placeholders for later fill-in. * `PSPublishModule.psd1`: remove `Convert-CommandsToList` from `FunctionsToExport`.
…, and `FileVersion` in .csproj * Prefer `VersionPrefix` when reading current version; fall back to `AssemblyVersion` and `FileVersion`. * Update `Update-VersionInCsProj.ps1` to replace `VersionPrefix`, `AssemblyVersion`, and `FileVersion` when present. * Update `Set-ProjectVersion.md` to document that .csproj files have those elements updated.
…alVersion` in .csproj handling * Read additional version tags (`<Version>`, `<PackageVersion>`, `<InformationalVersion>`) in `Get-CurrentVersionFromCsProj` * Update `Update-VersionInCsProj` to replace and persist those tags when present * Align documentation (`Set-ProjectVersion.md`) to list all supported .csproj version elements This improves handling for SDK-style projects and pack scenarios by ensuring all common version properties are detected and updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several documentation and code improvements related to handling versioning in C# projects and PowerShell modules, as well as enhancements to assembly metadata extraction. The most significant changes include expanding support for version detection and updating in
.csprojfiles, refactoring documentation for clarity and completeness, and improving robustness in PowerShell assembly metadata analysis.Versioning improvements in C# project handling:
.csprojfiles now checks multiple tags in order of precedence:VersionPrefix,Version,PackageVersion,AssemblyVersion,FileVersion, and numeric-onlyInformationalVersion. This ensures more reliable version detection across different project styles. (Private/Get-CurrentVersionFromCsProj.ps1)Version,VersionPrefix,PackageVersion,AssemblyVersion,FileVersion,InformationalVersion) when present, rather than justVersionPrefix. This provides more comprehensive version updates for SDK-style and legacy projects. (Private/Update-VersionInCsProj.ps1) [1] [2]Set-ProjectVersionand related functions is updated to clarify which tags are affected and how versioning is handled for.csprojfiles. (Docs/Set-ProjectVersion.md)Documentation refactoring and parameter descriptions:
Publish-GitHubReleaseAssetis refactored for clarity: redundant examples are removed, parameter descriptions are replaced with placeholders for future completion, and parameter documentation is reorganized for easier reading and maintenance. (Docs/Publish-GitHubReleaseAsset.md) [1] [2] [3] [4] [5] [6] [7] [8]PowerShell assembly metadata extraction robustness:
System.Management.Automationin different ways, and ensure unique results. This makes metadata extraction more reliable across various build and runtime scenarios. (Public/Get-PowerShellAssemblyMetaData.ps1)Module manifest update:
PSPublishModule.psd1)