Skip to content

feat: show full distance e-receipt on hover for map distance requests#92525

Merged
mountiny merged 3 commits into
Expensify:mainfrom
software-mansion-labs:feat/zoom-map-e-receipts
Jun 8, 2026
Merged

feat: show full distance e-receipt on hover for map distance requests#92525
mountiny merged 3 commits into
Expensify:mainfrom
software-mansion-labs:feat/zoom-map-e-receipts

Conversation

@WojtekBoman

@WojtekBoman WojtekBoman commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

On hover over a map distance expense receipt, overlay the full distance e-receipt (map + amount + waypoints) scaled with object-fit:contain to fit the fixed receipt box without resizing it, matching Expensify Classic. Adds the HoveredDistanceEReceipt component, wires it into MoneyRequestReceiptView (gated on isMapDistanceRequest && hovered), and a new eReceiptHoverFill style.

Fixed Issues

$ #90793 (comment)
PROPOSAL:

Tests

  1. Open a report and create (or open) a map-based distance expense (created via the map/route flow, not a manually entered distance).
  2. Open the report/transaction so the receipt thumbnail (the map preview) is visible in the receipt box.
  3. Hover the mouse over the receipt box.
  4. Verify that the full distance e-receipt (map + amount + waypoints) appears as an overlay, scaled down to fit entirely inside the receipt box.
  5. Verify that the receipt box does not change size or shift while hovering, and that there is no white gap around the scaled card (the surrounding fill matches the card background).
  6. Move the mouse off the receipt and verify the overlay disappears, returning to the plain map thumbnail.
  7. Repeat for a manually entered distance expense and verify the hover overlay does not appear.
  • Verify that no errors appear in the JS console

Offline tests

  1. Go offline.
  2. Open a report containing a map distance expense.
  3. Hover over the receipt box and verify the full distance e-receipt overlay still renders from cached transaction data (map, amount, waypoints).

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@codecov

codecov Bot commented Jun 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/styles/index.ts 59.06% <ø> (ø)
...nents/ReportActionItem/MoneyRequestReceiptView.tsx 69.95% <92.30%> (+0.24%) ⬆️
...nents/ReportActionItem/HoveredDistanceEReceipt.tsx 6.66% <6.66%> (ø)
... and 524 files with indirect coverage changes

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@shawnborton

Copy link
Copy Markdown
Contributor

Works great on my end :thu

@shawnborton

Copy link
Copy Markdown
Contributor

Works great on my end 👍 nice work!

@WojtekBoman WojtekBoman marked this pull request as ready for review June 3, 2026 15:17
@WojtekBoman WojtekBoman requested review from a team as code owners June 3, 2026 15:17
@melvin-bot melvin-bot Bot requested review from QichenZhu and heyjennahay and removed request for a team June 3, 2026 15:17
@melvin-bot

melvin-bot Bot commented Jun 3, 2026

Copy link
Copy Markdown

@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 863ed13207

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/components/ReportActionItem/MoneyRequestReceiptView.tsx Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a desktop hover overlay for map-based distance receipts so reviewers can see the full distance e-receipt (map + amount + waypoints) inside the fixed receipt box (scaled to “contain”), matching Expensify Classic behavior.

Changes:

  • Introduces HoveredDistanceEReceipt to render a scaled, contained full distance e-receipt overlay.
  • Wires the overlay into MoneyRequestReceiptView behind isMapDistanceRequest && hovered.
  • Adds an eReceiptHoverFill style to ensure the overlay background matches the e-receipt panel (no visible gap around the scaled card).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/styles/index.ts Adds a background fill style used by the hover overlay to match the distance e-receipt background.
src/components/ReportActionItem/MoneyRequestReceiptView.tsx Renders the hover overlay for map distance receipts and introduces isMapDistanceRequest gating.
src/components/ReportActionItem/HoveredDistanceEReceipt.tsx New component that measures the receipt box + e-receipt and scales the overlay to fit (“contain”).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +175 to +176
const isDistanceRequest = isDistanceRequestTransactionUtils(transaction);
const isMapDistanceRequest = !!transaction && isDistanceRequest && !isManualDistanceRequest(transaction);

@QichenZhu QichenZhu Jun 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is genuine.

Steps to reproduce:

  1. Create a map distance expense.
  2. Create a manual distance expense.
  3. Merge the 2nd expense into the 1st expense and select the 1st expense as the merchant to keep.

Expected result:

E-receipt displays on hover.

Actual result:

Only the map enlarges on hover.

Screen.Recording.2026-06-04.at.10.55.21.PM.mov

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it should work fine, I've added here logic checking if the transaction has defined waypoints, if so, we'll display an e-receipt

@@ -623,23 +623,28 @@ function MoneyRequestReceiptView({
isEnabled={canZoomReceipt}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E-receipts zoom on hover is intended

Comment thread src/components/ReportActionItem/HoveredDistanceEReceipt.tsx
@trjExpensify trjExpensify requested review from trjExpensify and removed request for heyjennahay June 3, 2026 21:46
trjExpensify
trjExpensify previously approved these changes Jun 3, 2026

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too 👍

@QichenZhu QichenZhu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clicking the thumbnail doesn't open the receipt modal. Is this intentional?

92525.mov

@dannymcclain

Copy link
Copy Markdown
Contributor

Clicking the thumbnail doesn't open the receipt modal. Is this intentional?

No it should open the receipt modal. But the weird thing is the first time I clicked it, it worked as expected, but then after that first time, clicking did nothing.

Comment thread src/components/ReportActionItem/HoveredDistanceEReceipt.tsx Outdated
Comment thread src/components/ReportActionItem/MoneyRequestReceiptView.tsx Outdated
@WojtekBoman

Copy link
Copy Markdown
Contributor Author

@QichenZhu @Expensify/design All comments have been resolved :) Feel free to generate new builds!

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@QichenZhu

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
    Allow receipt zooming where customers can roll over receipts with the mouse to zoom in #90793 (comment)
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
    https://expensify.slack.com/archives/C049HHMV9SM/p1778663561704459
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-06-09.at.12.37.02.AM.mov
Android: mWeb Chrome
Screen.Recording.2026-06-09.at.12.39.18.AM.mov
iOS: HybridApp
Simulator.Screen.Recording.-.iPhone.17.-.2026-06-09.at.00.36.12.mov
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.17.-.2026-06-09.at.00.38.40.mov
MacOS: Chrome / Safari
mac-desktop-1.mov
mac-desktop-2.mov

mountiny
mountiny previously approved these changes Jun 8, 2026

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Expensify/design Please give it a look

Comment thread src/components/ReportActionItem/HoveredDistanceEReceipt.tsx Outdated
Comment thread src/components/ReportActionItem/MoneyRequestReceiptView.tsx
@shawnborton

Copy link
Copy Markdown
Contributor

Works well on my end 👍

@mountiny mountiny merged commit 9ee91f7 into Expensify:main Jun 8, 2026
33 checks passed
@OSBotify

OSBotify commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.1-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

Help site review — no docs changes required

I reviewed the changes in this PR against the help site articles under App/docs/articles.

Conclusion: No help site updates are needed.

Why:

  • This PR is a purely visual, web-only hover interaction: hovering over a map distance expense receipt thumbnail overlays the full distance e-receipt (map + amount + waypoints), scaled with object-fit: contain to fit the existing receipt box without resizing it. It's a presentation refinement to match Expensify Classic.
  • It introduces no new feature, setting, tab, label, button, or change to any user-facing workflow. The only changes are a new internal component (HoveredDistanceEReceipt), gating logic in MoneyRequestReceiptView, and a CSS style.
  • The relevant article — Distance Expenses — documents how to create and edit distance expenses and what receipts represent. Help articles intentionally describe workflows and features, not transient UI affordances like hover-to-zoom, so there is nothing to add or correct.

Because no documentation changes are required, I did not create a draft help site PR.

@WojtekBoman, if you believe this hover behavior should be documented (or if I'm missing a customer-facing change), let me know and I'll draft the help site PR.

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #93001 was identified to be related to this PR.

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #93004 was identified to be related to this PR.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #93010 was identified to be related to this PR.

@mountiny

mountiny commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Ended up reverting so we can handle those edge cases in v2

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.1-6 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.