Use promises and fetch instead of eventemitter and xhr #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I was about to write exactly this library (and probably some of its ecosystem) until I found yours :).
Great work standardising the weird bits under the hood!
I'd love it if it would be slimmer though, and I think it's totally doable :).
This PR cuts down almost half the size by implementing
fetchinstead ofxhrand by usingPromiseinstead ofEventEmitter.Events are gone but a communication channel can be introduced as an option if truly needed.
I'd love to hear your thoughts about this.
Thanks!
Darío