Skip to content

get/set currentTime for buffer source #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fergalhanley wants to merge 1 commit into
base: master
Choose a base branch
from
+22 −0
Open

get/set currentTime for buffer source #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions lib/buffer-source.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,28 @@ function createBufferSource (src, opt) {
return duration
}
},
currentTime: {
enumerable: true, configurable: true,
get: function () {
if (!playing)
return audioCurrentTime
else
return audioCurrentTime + (rightNow() - audioStartTime) / 1000
Copy link
Contributor

@dy dy Jun 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess buffer source time is better be based on audioContext.currentTime than "browser time"

},
set: function (n) {
if(typeof n !== 'number' || n > duration) {
throw new Error('invalid set currentTime = ' + n + ' for audio with duration = ' + duration);
}
if (playing) {
emitter.pause()
audioCurrentTime = n
emitter.play()
}
else {
audioCurrentTime = n
}
}
},
playing: {
enumerable: true, configurable: true,
get: function () {
Expand Down