Add support for wildcard entity IDs#581
Open
OskarLinde wants to merge 1 commit intoExperienceLovelace:masterfrom
Open
Add support for wildcard entity IDs#581OskarLinde wants to merge 1 commit intoExperienceLovelace:masterfrom
OskarLinde wants to merge 1 commit intoExperienceLovelace:masterfrom
Conversation
Member
|
Hi, Thanks for the PR. Much appreciated. Could I kindly ask you to include testing for alle scenarios? A valid wildcard, and a non-valid (error printed in the logs). Please find the most related test-file and make, run and validate the mentioned test, so we're sure it's working now; but also in the future. Please don't touch the existing https://github.com/ExperienceLovelace/ha-floorplan/blob/master/tests/jest/tests/ |
Member
|
Hi, Did you find time to look into this? :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This diff adds the option to use wildcards to specify entity rules. This can save a lot of typing and need to manually update rule files when adding additional entities to the system.
Examples
Light Rule:
Temperature Visualization Rule:
Door State Visualization: