Open
Conversation
BundleMonNo change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
MatiasArriola
requested changes
Oct 24, 2025
Contributor
MatiasArriola
left a comment
MatiasArriola
left a comment
There was a problem hiding this comment.
Thanks @anagperal !
Looks good to me, just a comment
Comment on lines
50
to
64
| attributes: enrollment.attributes.map(att => { | ||
| const mappedAttributeId = | ||
| trackedEntityAttributesToTEI[att.attribute]?.mappedId ?? att.attribute; | ||
|
|
||
| const mappedValue = mapOptionValue(att.value, [ | ||
| trackedEntityAttributesToTEI[att.attribute]?.mapping ?? {}, | ||
| this.mapping, | ||
| ]); | ||
|
|
||
| return { | ||
| ...att, | ||
| attribute: mappedAttributeId, | ||
| value: mappedValue, | ||
| }; | ||
| }), |
Contributor
There was a problem hiding this comment.
This could be extracted to a function to avoid code duplication (same is done for attributes and enrollment.attributes).
Even if it is a helper inside the method like const mapAttribute = (att: TrakedEntityAttribute) => { [...] I think it would be a good option
MatiasArriola
approved these changes
Oct 24, 2025
Contributor
MatiasArriola
left a comment
MatiasArriola
left a comment
There was a problem hiding this comment.
Nice @anagperal! Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 References
📝 Implementation
📹 Screenshots/Screen capture
Error before:
Now success
🔥 Is there anything the reviewer should know to test it?
📑 Others
Any change in the GUI library? If so, what branch/PR?
Any change in the D2 Api? If so, what branch/PR?