Constant audit
#5146
Open
Constant audit
#5146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Constant` IR op needs the frontend to be audited and pass padding information through.
`ThreadRemoveCodeEntry` doesn't properly have relations wired up but it does use the Entry. So this would be broken on code caching with relocations.
All direct usages have been audited. Now we need to do indirect usages through the `Constant` IR operation.
Kind of annoying that it is overlapping with LoadConstant. NFC
Fixes an issue that a potential same constant could be padded for one use and not padded for another.
`MOVGPRImmediate` is changing in another PR and we need to come back to it.
All use cases now pass a pad type in to this.
Default argument is no longer used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #5140, and #5142 merged first.
The final audit step. Goes through all instances of
Constant(...)usage and determines if any of these need padding or not.The main takeaway is that all RIP relative accesses tend to do
_EntryPointOffsetplus some immediate which never changes, and the_EntryPointOffsetis always using a FEX relocation. Additionally if the frontend informs if anything is a guest side relocation, those literal get fully relocated as well.Nothing too scary in here, but that wraps up the audit and now all constant generation is explicit about needing padding or not.