-
Notifications
You must be signed in to change notification settings - Fork 223
[cmake] FEXConfig: use one qrc #5155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
So Qt 5 doesn't support QML modules from CMake. I guess qmldir it is 😵💫 |
b44fddc to
00a5b1e
Compare
618d299 to
e1b7b3c
Compare
|
Note for self: Qt 5 supports only old var style https://doc.qt.io/archives/qt-5.15/qtcore-cmake-qt5-add-resources.html No idea what to do at this point. The evil part of me says "drop Qt 5" but the 3 Ubuntu 20.04 users will impale me with pitchforks. The evil but slightly less pitchfork-risky solution is to just write the file manually. The slightly less evil idea is to do configure_file or something |
Well, we only support back to Ubuntu 22.04, but it also doesn't have QT6 in the base packages (It's in backports I think?) which means the PPA builder can't rely on it. |
|
Actually the package search indicates 6.2 is just in Universe https://packages.ubuntu.com/search?suite=jammy&arch=any&searchon=names&keywords=qt6-declarative |
|
Okay so at this point there are two options:
Final decision is not up to me, but option 1 should probably be done in a more formal manner where the deprecation/dropping is warned to users and developers + via the wiki. So my vote is for option 2 even though it somewhat pains me. |
|
Rather than manually creating a Qt 5 and Qt 6 QRC, instead we create a single qrc that references a flattened directory. Then, we copy each of its dependents (main, dialogs, icon) into the binary directory as-is, resulting in just one qrc rather than having to maintain one for each. Signed-off-by: crueter <[email protected]>
Rather than manually creating a Qt 5 and Qt 6 QRC, instead we create a
single qrc that references a flattened directory. Then, we copy each of
its dependents (main, dialogs, icon) into the binary directory as-is,
resulting in just one qrc rather than having to maintain one for each.
Signed-off-by: crueter [email protected]