[externals] use ankerl::unordered_dense over std and tsl #5162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankerl::unordered_dense is faster on average and has less memory usage than both std::unordered_map and tsl::robin_map. It's also seemingly better maintained, and shouldn't need an extra patch on top of upstream. Obviously, this will need a lot of testing. Signed-off-by: crueter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ankerl::unordered_dense is faster on average and has less memory usage
than both std::unordered_map and tsl::robin_map. It's also seemingly
better maintained, and shouldn't need an extra patch on top of upstream--this has the added benefit of allowing users to use the system unordered_dense package, which I'm sure the Gentoo packagers will appreciate. Plus it will complement #5159 nicely :)
Obviously, this will need a lot of testing.
Signed-off-by: crueter [email protected]