Skip to content

Conversation

@PoeticPete
Copy link

There are instances where a view will be first responder, but we still want to allow keyboard shortcuts.

This change adds an ignore-list for allowing FLEX keyboard shortcuts even if there is a first responder on the given classes.

@NSExceptional
Copy link
Collaborator

Why the simulator specific language? I don't think these are specific to the simulator, are they? Do they not also work when you have a bluetooth keyboard connected to the device?

(If they are simulator-only, we need to add some /// comments to this class to reflect that)

@PoeticPete
Copy link
Author

Why the simulator specific language? I don't think these are specific to the simulator, are they? Do they not also work when you have a bluetooth keyboard connected to the device?

(If they are simulator-only, we need to add some /// comments to this class to reflect that)

This logic indeed simulator specific. See registerSimulatorShortcutWithKey for more context.

The comments above the new methods already mention simulator. The entire Classes/Utility/Keyboard/FLEXKeyboardShortcutManager.m is already gated to simulators only. Is the request to add comments at the top of FLEXKeyboardShortcutManager.h? That feels a little beyond the scope of this PR, but I'd be happy to publish a new one addressing that.

@NSExceptional
Copy link
Collaborator

My bad! No, sorry, I just haven't touched this code in a long while so I wasn't sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants