Ipforwarding modify #18316
Open
Ipforwarding modify #18316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert the `ip forwarding` command to use the northbound code. Signed-off-by: Donald Sharp <[email protected]>
This code had not been converted, convert it over. Signed-off-by: Donald Sharp <[email protected]>
The original max-multipath state value was put down in the middle of the config section. It really belongs in the state, so let's move it. Signed-off-by: Donald Sharp <[email protected]>
donaldsharp
force-pushed
the
ipforwarding_modify
branch
from
6adbd05 to
a4a805b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a) Move max-multicast to a state value
b) Convert
ip forwardingto yangc) Convert
ipv6 forwardingto yangI am doing something wrong with this conversion, in that I am not seeing the config values reflected in yang when I ask for it. I do not know what I am missing or doing wrong and would like some help figuring it out. When I issue:
show mgmt get-data /frr-zebra:zebra with-defaults allshow mgmt get-data /frr-zebra:zebra with-configshow mgmt get-data /frr-zebra:zebra only-configI do not see the ip|ipv6 forwarding yang show up there.
When I issue the
show mgmt get-config /frr-zebra:zebraI only see the default values as defined in yangI do know that yang-conversion is being accepted by the system as that I can toggle forwarding on/off.
I also see this problem with the zapi packets command as well. It is accepted,
show runreflects it and I canstop the code and see that it is working, I just cannot get the yang data to show it.