bgpd,configure: vrf leak setting nexthop as vrf interface #18320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donaldsharp
reviewed
Mar 5, 2025
mjstapp
reviewed
Mar 5, 2025
|
I wouldn't mind a |
chiragshah6
force-pushed
the
bgp_dev4
branch
2 times, most recently
from
90d3bd6 to
e62f297
Compare
louis-6wind
suggested changes
Mar 6, 2025
|
yes, that's what I was thinking. I think it's better if everything is compiled together, etc. And if there's a command-line control, this could be tested more easily too... even with a topotest.
|
Certain switch AISCs do not have capability for vrf leaked routes
to point to another VRF and perform second route lookup via chaining
multiple tables.
The routes need proper l3 interface in order to do forwarding in
ASIC in target VRF table.
Hence, moving the setting the nexthop as source vrf to a specific flag.
The following is a connected route with nexthop as VRF tenant1 breaks the HW forwarding
it needs proper l3 interface (captured in output2).
Output-1:
mlx-4:mgmt:# ip -d route show vrf tenant2 21.1.0.0/16
unicast 21.1.0.0/16 nhid 331 proto bgp scope global metric 20
nh_info id 331 dev tenant1 scope host proto zebra
Output-2:
mlx-3:mgmt:# ip -d route show vrf tenant2 21.1.0.0/16
unicast 21.1.0.0/16 nhid 183 proto bgp scope global metric 20
nh_info id 183 dev vlan101 scope host proto zebra <<<< L3 interface vlan101
Following four commits introduced the vrf nexthop change:
31fc89b bgpd, tests: fix route leaking from the default l3vrf
db7cf73 bgpd: fix interface on leaks from redistribute connected
067fbab bgpd: fix interface on leaks from network statement
8a02d9f bgpd: Set nh ifindex to VRF's interface, not the real
Signed-off-by: Chirag Shah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain switch AISC do not have capability for vrf leaked routes to point to another VRF and perform second route lookup via chaining multiple tables.
The routes need proper l3 interface in order to do forwarding in ASIC in target VRF table.
Hence, moving the setting the nexthop as source vrf to a specific flag.
The following is a connected route with nexthop as VRF tenant1 breaks the HW forwarding it needs proper l3 interface (captured in output2).
Output-1:
Output-2:
Following four commits introduced the vrf nexthop change:
Signed-off-by: Chirag Shah [email protected]