Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bgp evpn testing related to non default EVPN backbone #18358

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Bgp evpn testing related to non default EVPN backbone #18358

wants to merge 4 commits into from
+406 −20

Conversation

pguibert6WIND
Copy link
Member

Add some more testing:

  • use non default BGP instance as EVPN instance
  • test source-vrf filtering command

@pguibert6WIND
Copy link
Member Author

ci:rerun

@pguibert6WIND pguibert6WIND mentioned this pull request Mar 12, 2025
Open
2 tasks
ton31337
ton31337 reviewed Mar 12, 2025
View reviewed changes
tests/topotests/bgp_evpn_rt5/test_bgp_evpn.py Outdated

tgen.gears["r2"].vtysh_cmd(
"""
configure terminal\n
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop \n chars from every line, it's not necessary.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

ton31337
ton31337 reviewed Mar 12, 2025
View reviewed changes
tests/topotests/bgp_evpn_rt5/test_bgp_evpn.py Outdated

tgen.gears["r2"].vtysh_cmd(
"""
configure terminal\n
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@pguibert6WIND
topotests: bgp_evpn_rt5, use a non default vrf for evpn backbone
29989bc 
Change the test, and move the backbone evpn to a non default vrf.

Signed-off-by: Philippe Guibert <[email protected]>
@pguibert6WIND
topotests: add bgp l3vpn importation test behind bgp evpn setup
46266eb 
Add a BGP L3VPN setup with ability to import L3VPN prefixes, behind EVPN
setup. Two BGP sessions are configured between R2 and R4, and are
shutdown, then used at the end of the test; then filtering is applied.

Signed-off-by: Philippe Guibert <[email protected]>
@pguibert6WIND
bgpd: do not update default bgp instance as bgp evpn at creation
743d6eb 
After creating a default BGP instance, the configuration of a VRF BGP
instance used as EVPN backbone is not possible, the below error message
appears:

> %% Please unconfigure EVPN in default VRF

Actually, at default BGP creation, the EVPN backbone is set, whereas
this instance can be used for something else. Fix this by not setting
too early the EVPN setup.

Fixes: ("e2f3a930c54c") bgpd: Allow non-default instance to be EVPN one

Signed-off-by: Philippe Guibert <[email protected]>
@pguibert6WIND
bgpd: fix remove too verbose error message
c5f826f 
When setting up a RR EVPN setup on a non default BGP EVPN instance, the
below error message is displayed for each received BGP update.

> 2025/03/11 14:38:24.959177 BGP: [J51AF-GQ2HJ][EC 33554468] vrf import rt lookup - evpn instance not created yet
> 2025/03/11 14:38:24.959188 BGP: [J51AF-GQ2HJ][EC 33554468] vrf import rt lookup - evpn instance not created yet

The message is just here to inform that there is no BGP backbone
defined, which is normal under a RR configuration. This message does not
break anything functionally, and should be removed.

Signed-off-by: Philippe Guibert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ton31337 ton31337 ton31337 left review comments

Assignees
No one assigned
Labels
bgp bugfix master size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pguibert6WIND @ton31337