Firework Star Explosion Type Registry #4932
Open
+162
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekulxam
reviewed
Oct 18, 2025
Contributor
ekulxam
left a comment
ekulxam
left a comment
There was a problem hiding this comment.
Looks good, just left some nit comments.
| /** | ||
| * A registry for the {@link FireworkExplosionComponent.Type} of an item for the {@link FireworkStarRecipe}. | ||
| */ | ||
| public final class FireworkStarExplosionTypeRegistry { |
Contributor
There was a problem hiding this comment.
The name of this class seems misleading, as it appears to be a registry for the crafting recipe's map rather than the actual Type enum. Consider changing this to FireworkStarExplosionTypeRecipeRegistry (although this also seems a bit verbose?).
| * @param item the item to register | ||
| * @param explosionType the firework explosion type | ||
| */ | ||
| public static void register(ItemConvertible item, FireworkExplosionComponent.Type explosionType) { |
Contributor
There was a problem hiding this comment.
I believe the logic in here should be moved to the impl class, and this method should only be calling a register method in the impl class instead.
Contributor
|
Hi @8s2, I see the PR’s been inactive for a while. I’m interested in helping push it forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a registry for firework explosion types for items when crafting a firework star.