Skip to content

Conversation

@sylv256
Copy link
Member

@sylv256 sylv256 commented Jan 14, 2026

Description

Implements #5035; fixes #4920; fixes #5045.

See #5045 for detailed description.

API

This PR implements the following...

DebugRendererRegistry

Registry for custom debug renderers.

ClientDebugSubscriptionRegistry

A registry for debug subscriptions on the client, allowing listening to registered debug subscriptions on the client.

EntityDebugSubscriptionRegistry

A server-side registry for debug subscriptions specific to entities or properties of entities.

Testing

To test this mod, use the Testmod Client, then spawn a Mannequin. It should look something like this:
image

@sylv256 sylv256 added enhancement New feature or request new module Pull requests that introduce new modules labels Jan 14, 2026
@sylv256 sylv256 added the tests PR has tests label Jan 14, 2026
Copy link
Member

@LambdAurora LambdAurora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good from a quick glance.
Just a little nitpick.

import net.minecraft.client.Minecraft;
import net.minecraft.client.renderer.debug.DebugRenderer;

/// A constructor for a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: I would never call or describe an interface as "a constructor", this word has already a very specific meaning in Java, and we should stick to it.
This is a factory interface, and should be described as such.

We could instead say A factory to create a [debug subscription][...] renderer. instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to fix this when I get time (probably this Saturday EST) as I have university starting tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request new module Pull requests that introduce new modules tests PR has tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Debug API Add DebugRenderer init event

2 participants