-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: build snap package #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b279ec9
to
8d06dac
Compare
ctrlaltf24
reviewed
Feb 10, 2025
snap/snapcraft.yaml
Outdated
|
||
oudedetai: | ||
source: https://github.com/FaithLife-Community/LogosLinuxInstaller.git | ||
# FIXME: just for testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ before merge
ctrlaltf24
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just change the branch in snapcraft.yml when you're ready to merge
fix: use updated name; add run script fix: missing pipe fix: set snap version fix: add wine stage packages fix: start with no config file fix: don't include ICU files in snap
fix: create ~/.cache dir if it doesn't exist fix: set oudedetai source as cloned repo fix: always build from local source fix: always build from repo main fix: set packages vars as empty strings fix: set packages var as empty list fix: use --skip-dependencies for snap
fix: store .cache in $SNAP_USER_COMMON fix: config file location fix: ensure config file exists at runtime fix: init config file with '{}' fix: remove libicudata.so files
feat: store RUNMODE as constant fix: augment LD_LIBRARY_PATH for libpxbackend feat: add wine subcommand fix: remove illegal chars fix: use bin/oudedetai command directly fix: add usr/lib/<arch> to LD_LIBRARY_PATH fix: rework env vars fix: rework env vars fix: simplify env, use local source fix: always deps check for snap fix: set version in build step fix: set version after build fix: set version in override-stage fix: use repo for source instead of local fix: add assets and img dirs fix: put assets/img in subdir fix: add / to define dirs fix: add pkg data in one part fix: use stage for assets/img fix: add assets/img dirs in oudedetai part fix: add assets/img during build step fix: rework parts fix: add plugin names fix: put pkgs in correct place
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix #237 #239
constants.RUNMODE
XDG_CACHE_HOME/FaithLife-Community
app.conf.user_download_dir
(there's a typo in the commit message...)