Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build snap package #298

Merged
merged 22 commits into from
Feb 10, 2025
Merged

feat: build snap package #298

merged 22 commits into from
Feb 10, 2025

Conversation

n8marti
Copy link
Collaborator

@n8marti n8marti commented Feb 6, 2025

Also fix #237 #239

  • add constants.RUNMODE
  • default downloads to XDG_CACHE_HOME/FaithLife-Community
  • add app.conf.user_download_dir (there's a typo in the commit message...)

@n8marti n8marti force-pushed the snap-pkg branch 4 times, most recently from b279ec9 to 8d06dac Compare February 10, 2025 06:15
@n8marti n8marti marked this pull request as ready for review February 10, 2025 06:17
@n8marti n8marti requested review from ctrlaltf24 and thw26 February 10, 2025 06:17
ou_dedetai/installer.py Outdated Show resolved Hide resolved
ou_dedetai/installer.py Show resolved Hide resolved
ou_dedetai/utils.py Outdated Show resolved Hide resolved
snap/gui/oudedetai.verbum.desktop Show resolved Hide resolved
snap/gui/oudedetai.logos.desktop Show resolved Hide resolved

oudedetai:
source: https://github.com/FaithLife-Community/LogosLinuxInstaller.git
# FIXME: just for testing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ before merge

ou_dedetai/network.py Show resolved Hide resolved
ou_dedetai/constants.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ctrlaltf24 ctrlaltf24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just change the branch in snapcraft.yml when you're ready to merge

fix: use updated name; add run script

fix: missing pipe

fix: set snap version

fix: add wine stage packages

fix: start with no config file

fix: don't include ICU files in snap
fix: create ~/.cache dir if it doesn't exist

fix: set oudedetai source as cloned repo

fix: always build from local source

fix: always build from repo main

fix: set packages vars as empty strings

fix: set packages var as empty list

fix: use --skip-dependencies for snap
fix: store .cache in $SNAP_USER_COMMON

fix: config file location

fix: ensure config file exists at runtime

fix: init config file with '{}'

fix: remove libicudata.so files
feat: store RUNMODE as constant

fix: augment LD_LIBRARY_PATH for libpxbackend

feat: add wine subcommand

fix: remove illegal chars

fix: use bin/oudedetai command directly

fix: add usr/lib/<arch> to LD_LIBRARY_PATH

fix: rework env vars

fix: rework env vars

fix: simplify env, use local source

fix: always deps check for snap

fix: set version in build step

fix: set version after build

fix: set version in override-stage

fix: use repo for source instead of local

fix: add assets and img dirs

fix: put assets/img in subdir

fix: add / to define dirs

fix: add pkg data in one part

fix: use stage for assets/img

fix: add assets/img dirs in oudedetai part

fix: add assets/img during build step

fix: rework parts

fix: add plugin names

fix: put pkgs in correct place
@ctrlaltf24 ctrlaltf24 linked an issue Feb 10, 2025 that may be closed by this pull request
@n8marti n8marti merged commit 9f1d89c into main Feb 10, 2025
@n8marti n8marti deleted the snap-pkg branch February 10, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Snap Support Change default download location to XDG_CACHE_HOME rather than downloads
2 participants