-
Notifications
You must be signed in to change notification settings - Fork 7
Break indexing documentation into subfolder with dedicated pages per index type #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the WalkthroughThe indexing documentation is restructured from a single file ( Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Comment |
Co-authored-by: gkorland <[email protected]>
Co-authored-by: gkorland <[email protected]>
|
@CodeRabbit review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
cypher/indexing/range-index.md (1)
161-161: Minor: Consider simplifying redundant phrase.Line 161 reads "matching nodes outside of the given radius" — for conciseness, "outside" alone suffices. This is a low-priority style improvement.
Apply this diff to simplify:
-Geospatial indexes can currently only be leveraged with `<` and `<=` filters; matching nodes outside of the given radius is performed using conventional matching. +Geospatial indexes can currently only be leveraged with `<` and `<=` filters; matching nodes outside the given radius are matched using conventional traversal.cypher/indexing/vector-index.md (1)
82-84: Minor: Verbose phrase can be simplified.Line 83 uses "At the moment" — consider using an adverb form like "Currently" for a more concise phrasing.
Apply this diff:
-Please note, when creating a vector index, both the vector dimension and similarity function -must be provided. At the moment the only supported similarity functions are 'euclidean' or 'cosine'. +Please note, when creating a vector index, both the vector dimension and similarity function +must be provided. Currently, the only supported similarity functions are 'euclidean' or 'cosine'.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
cypher/index.md(1 hunks)cypher/indexing.md(0 hunks)cypher/indexing/fulltext-index.md(1 hunks)cypher/indexing/index.md(1 hunks)cypher/indexing/range-index.md(1 hunks)cypher/indexing/vector-index.md(1 hunks)cypher/procedures.md(1 hunks)index.md(1 hunks)
💤 Files with no reviewable changes (1)
- cypher/indexing.md
🧰 Additional context used
🪛 LanguageTool
cypher/indexing/vector-index.md
[style] ~83-~83: For conciseness, consider replacing this expression with an adverb.
Context: ...d similarity function must be provided. At the moment the only supported similarity functions...
(AT_THE_MOMENT)
cypher/indexing/range-index.md
[style] ~161-~161: This phrase is redundant. Consider using “outside”.
Context: ...th < and <= filters; matching nodes outside of the given radius is performed using con...
(OUTSIDE_OF)
🪛 markdownlint-cli2 (0.18.1)
cypher/indexing/range-index.md
78-78: Multiple spaces after hash on atx style heading
(MD019, no-multiple-space-atx)
79-79: Multiple spaces after hash on atx style heading
(MD019, no-multiple-space-atx)
202-202: Multiple headings with the same content
(MD024, no-duplicate-heading)
203-203: Multiple headings with the same content
(MD024, no-duplicate-heading)
204-204: Multiple spaces after hash on atx style heading
(MD019, no-multiple-space-atx)
204-204: Multiple headings with the same content
(MD024, no-duplicate-heading)
205-205: Multiple spaces after hash on atx style heading
(MD019, no-multiple-space-atx)
206-206: Multiple spaces after hash on atx style heading
(MD019, no-multiple-space-atx)
315-315: Multiple headings with the same content
(MD024, no-duplicate-heading)
318-318: Multiple headings with the same content
(MD024, no-duplicate-heading)
321-321: Multiple headings with the same content
(MD024, no-duplicate-heading)
🔇 Additional comments (6)
cypher/index.md (1)
45-45: Link structure correctly updated for folder navigation.Adding the trailing slash properly directs users to the new indexing folder structure and the index.md overview page.
index.md (1)
33-33: Homepage links correctly route to dedicated index type documentation.The three feature links now direct users to focused, type-specific pages rather than anchors in a monolithic page, improving discoverability and user navigation flow.
cypher/indexing/index.md (1)
1-32: Indexing overview page correctly structured as parent with children.The navigation hierarchy is properly set up with
has_children: trueand relative links to child pages. The nav_order of 21 positions this appropriately after Procedures. However, verify that this nav_order doesn't introduce unexpected ordering relative to other Cypher Language sections—if the Cypher Language children list feels misaligned after this change, you may want to reorder or adjust neighboring nav_order values.cypher/indexing/fulltext-index.md (1)
1-317: Full-text index documentation is comprehensive and well-structured.The page clearly explains RediSearch integration, configuration options (language, stopwords, phonetic), and provides practical examples for both node and relationship indexing. The nav_order: 2 correctly places it as the second index type, and multi-language code samples are consistent with the repository's patterns.
cypher/indexing/vector-index.md (1)
1-201: Vector index documentation is clear and complete.The page provides excellent coverage of vector index operations, configuration options, and multi-language examples. The reference to
/cypher/functions#vector-functionshelpfully connects vector creation to the functions reference. nav_order: 3 correctly orders it as the third index type.cypher/procedures.md (1)
42-44: Procedure cross-references correctly updated to new documentation structure.The full-text and vector procedure entries now properly link to their dedicated documentation pages instead of anchors in a monolithic file. New vector procedures are properly documented with arguments and yields.
|
@copilot please see the two comments from CodeRabbit: cypher/indexing/range-index.md -Geospatial indexes can currently only be leveraged with And cypher/indexing/vector-index.md -Please note, when creating a vector index, both the vector dimension and similarity function |
…okenization) Co-authored-by: gkorland <[email protected]>
I've extended the full-text search documentation with a new "Query Syntax and Features" section covering:
Each feature includes code examples in all supported languages and links to the RediSearch query syntax documentation. Commit: 3feaabd |
…ex docs Co-authored-by: gkorland <[email protected]>
Applied both CodeRabbit suggestions:
Commit: bf40cdf |
|
@copilot please fix the spellchecker |
Co-authored-by: gkorland <[email protected]>
|
@copilot can you please review these comments?
|
…examples, and best practices Co-authored-by: gkorland <[email protected]>
I've implemented all suggested improvements across all three index type pages: Range Index:
Full-text Index:
Vector Index:
All Pages Include:
Commit: bdc609a |
|
@copilot please make sure cypher/indexing.html redirects to cypher/indexing/index.md |
Co-authored-by: gkorland <[email protected]>
Added redirect configuration to
This uses the Commit: 965d37e |
|
@copilot it seem the spellcheck still failing |
…deoff, unnormalized) Co-authored-by: gkorland <[email protected]>
Breaking the Indexing Page into a Folder with Sub-Pages ✅
This PR successfully restructures the documentation for indexing by breaking the single
indexing.mdfile into a folder structure with separate pages for each type, and adds comprehensive best practices, performance guidance, and validation examples.Completed Tasks:
indexingfolder in/home/runner/work/docs/docs/cypher/index.mdin the indexing folder as the parent page with overview contentrange-index.mdfor Range Index documentationfulltext-index.mdfor Full-text Index documentationvector-index.mdfor Vector Index documentationindexing.mdfileChanges Summary:
New Structure Created:
URL Redirects (Backward Compatibility):
redirect_fromconfiguration to handle legacy URLs:/cypher/indexing.html→/cypher/indexing//cypher/indexing→/cypher/indexing/jekyll-redirect-fromplugin for seamless redirectionNavigation Hierarchy:
index.mdwithhas_children: trueandparent: "Cypher Language"parent: "Indexing"andgrand_parent: "Cypher Language"nav_orderfor consistent orderingUpdated References:
/index.md- Main homepage now links directly to specific index types/cypher/procedures.md- Procedure documentation links updated/cypher/index.md- Parent Cypher page link updatedExtended Full-Text Search Documentation (Fixes #287):
Added comprehensive "Query Syntax and Features" section covering:
*wildcard for autocomplete-style searches%term%distancesyntax for typo-tolerant searchesEach feature includes:
Comprehensive Documentation Enhancements:
Each index type page now includes:
Range Index Enhancements:
Full-text Index Enhancements:
Vector Index Enhancements:
Wording Improvements:
Spellcheck Updates:
.wordlist.txt:Files Changed:
cypher/indexing.md(863 lines)Benefits:
✅ Better organization - each index type has its own dedicated page
✅ Easier navigation - users can directly access the index type they need
✅ Improved maintainability - changes to one index type don't affect others
✅ Consistent with existing documentation structure (follows patterns from
/algorithms/and/commands/)✅ All internal links updated - no broken references
✅ Backward compatibility - old URLs redirect to new structure seamlessly
✅ Comprehensive full-text search examples for common use cases (fuzzy, prefix, tokenization)
✅ Clearer, more professional wording throughout
✅ Spellcheck passes successfully - all technical terms properly whitelisted
✅ Complete performance guidance - helps users choose the right index type
✅ Validation examples - users can verify their indexes are working correctly
✅ Real-world examples - practical code in all supported languages
✅ Best practices - clear guidance on when and how to use each index type
✅ Parameter guidance - detailed explanations for vector index tuning
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Summary by CodeRabbit
Documentation