Skip to content

Replace SharpZipLib with SharpCompress - #610

Open
ITaluone wants to merge 2 commits into
Fallout-build:developfrom
ITaluone:feat/replace-sharpziplib-with-sharpcompress
Open

Replace SharpZipLib with SharpCompress#610
ITaluone wants to merge 2 commits into
Fallout-build:developfrom
ITaluone:feat/replace-sharpziplib-with-sharpcompress

Conversation

@ITaluone

@ITaluone ITaluone commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Replaces the library SharpZipLib with SharpCompress.

Why?

  • SharpCompress has more features compared to SharpZipLib (especially the xz decompression)
  • No need to maintain two compressing libraries

Verification

Added the tests before doing anything and saving the directory hash from the "old" state, then replaced the compression lib and all tests stay green.

Request

Per #597 (comment)

@ITaluone
ITaluone requested a review from a team as a code owner July 30, 2026 10:39
@ITaluone
ITaluone requested a review from ChrisonSimtian July 30, 2026 10:39
@ITaluone ITaluone changed the title Feat/replace sharpziplib with sharpcompress Replace sharpziplib with sharpcompress Jul 30, 2026
@ITaluone ITaluone changed the title Replace sharpziplib with sharpcompress Replace SharpZipLib with SharpCompress Jul 30, 2026
@ITaluone ITaluone added enhancement New feature or request target/vNext Targets the next calendar-version labels Jul 30, 2026
@ITaluone
ITaluone force-pushed the feat/replace-sharpziplib-with-sharpcompress branch from ca67a25 to 6627a9b Compare July 30, 2026 11:00
Comment thread build/Build.Compression.cs Outdated

@ChrisonSimtian ChrisonSimtian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmk when you need a final review ;-) Enjoy your summer vacation :-)

Comment thread build/Build.cs
Comment thread src/Fallout.Utilities.IO.Compression/CompressionExtensions.cs
@ChrisonSimtian ChrisonSimtian added target/vCurrent Targets the current version and removed target/vNext Targets the next calendar-version labels Aug 11, 2026
@ITaluone
ITaluone force-pushed the feat/replace-sharpziplib-with-sharpcompress branch from 6627a9b to 17a466a Compare September 7, 2026 12:50
@ITaluone

ITaluone commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

@ChrisonSimtian After a long time, here we go again. This should be it now.

@ITaluone
ITaluone force-pushed the feat/replace-sharpziplib-with-sharpcompress branch 3 times, most recently from 4212509 to 426f4c1 Compare September 7, 2026 13:07
@ITaluone
ITaluone force-pushed the feat/replace-sharpziplib-with-sharpcompress branch from 426f4c1 to f773274 Compare September 7, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request target/vCurrent Targets the current version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants