Repository navigation
feat(web): NOTE_OPEN for a view, no member controls for a guest, gzipped island files - #916
Merged
Merged
Conversation
…_OPEN)
A frame's asks were the playhead's seven. A set's playlist has rows that
name their songs' notes and no way to go to one. NOTE_OPEN {path} is the
press the viewer would make in the app's own list: the page showing notes
opens it only where the viewer may (a share link's guest: a note the link
lists) and the ask is refused otherwise. It reads nothing.
A note opened on a link starts from its top: the page before it may have
been scrolled far down the list of the link's notes (#910).
(cherry picked from commit 81ac0a4)
…t or a write A link is this app opened as a guest; what a guest cannot do is a permission (guide/shares.md). The shell's own controls now say what they need (crate::permits: nothing, a vault, a write) and are drawn by what the viewer has: for a guest no Files, Open…, New note, Vault or Search, and no navigator drawer; Commands, Settings and the player are everyone's. The same shell and the same views: signed in, they are back. A link named for its root note draws that title once (#910). Seen at 390 px on a setlist's link: the two rows of member controls are gone, the list has their 85 px. (cherry picked from commit 9374477)
…wn files and those of notes it lists A share link's first load on a phone (#908, #602): the node sent an island's files as they are (Studio's web bundle is 8.0 MB of wasm, 3.7 MB gzipped). A script, module, sheet or wasm under /_ext/ is now sent gzipped to a browser that takes it, compressed once (each path is named by its content). A view on a note was handed the note's own images and lyrics, then every other file of the link up to the caps, so opening one song fetched every other song's cover. It is handed its own, then those of the notes it lists (a setlist's songs): a song gets its own only. (cherry picked from commit a4f480d)
…s and gzipped island files
fts-forge
Bot
force-pushed
the
land/05-web-guest-views
branch
from
November 19, 2026 06:01
147a7d1 to
d170f8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three commits:
NOTE_OPEN {path}: a frame's view may ask the app to open a note beside its own (a setlist's row, its song). The note opens only where the viewer may already open it (a share link's guest: a note the link lists). It reads nothing.docs/content/guide/shares.md), not a guest-only shell./_ext/is sent gzipped, compressed once; a note's view is handed its own files and those of the notes it lists, not every file of the link.The last commit adds the change file, the skill line for
NOTE_OPEN, and two lints inext_host.rs.Where it comes from
Part 5 of 8 of the Studio-distribution release (FastTrackStudios/studio#549): the sprint's commits from
stack/studio-distribution(input252a1651), cherry-picked unchanged (-x), with one commit after them for what a PR owes here: the change file, the skill, and the lints and tests the sprint branch never ran. The stack merges with merge commits; the top of the stack is the sprint tip's tree plus those fixes.How tested
On THEBATTLESHIP, in the devenv shell, at the top of the stack (what
mainwill be):cargo clippy --workspace --all-targetswith warnings denied, the feature buildsscripts/pr-scope.pynames, the web bundle's wasm build,xtaskfeature-tests,docs,surfaces,fleet-deps --check,core checkandboundaries, the whole nextest suite andxtask feature-tests --run. The last whole run of the suite passed 3,939 of 3,940; the one failure was the WebDAV test fixed in #914, which then passed five runs in a row, as did the feature builds and feature tests after the last fix (the clock in #912). That isscripts/lint-linux.sh's set, run in this worktree rather than a fresh clone. On each layer:cargo fmt --all --checkandcargo rail change check.Not run per layer: clippy and tests of the layers below the top.
🤖 Generated with Claude Code