Skip to content

feat(web): NOTE_OPEN for a view, no member controls for a guest, gzipped island files - #916

Merged
fts-forge[bot] merged 4 commits into
land/04-web-ogg-decodefrom
land/05-web-guest-views
Nov 19, 2026
Merged

fts-forge[bot] merged 4 commits into
land/04-web-ogg-decodefrom
land/05-web-guest-views

Conversation

@fts-forge

@fts-forge fts-forge Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Three commits:

The last commit adds the change file, the skill line for NOTE_OPEN, and two lints in ext_host.rs.

Where it comes from

Part 5 of 8 of the Studio-distribution release (FastTrackStudios/studio#549): the sprint's commits from stack/studio-distribution (input 252a1651), cherry-picked unchanged (-x), with one commit after them for what a PR owes here: the change file, the skill, and the lints and tests the sprint branch never ran. The stack merges with merge commits; the top of the stack is the sprint tip's tree plus those fixes.

How tested

On THEBATTLESHIP, in the devenv shell, at the top of the stack (what main will be): cargo clippy --workspace --all-targets with warnings denied, the feature builds scripts/pr-scope.py names, the web bundle's wasm build, xtask feature-tests, docs, surfaces, fleet-deps --check, core check and boundaries, the whole nextest suite and xtask feature-tests --run. The last whole run of the suite passed 3,939 of 3,940; the one failure was the WebDAV test fixed in #914, which then passed five runs in a row, as did the feature builds and feature tests after the last fix (the clock in #912). That is scripts/lint-linux.sh's set, run in this worktree rather than a fresh clone. On each layer: cargo fmt --all --check and cargo rail change check.

Not run per layer: clippy and tests of the layers below the top.

🤖 Generated with Claude Code

@fts-forge
fts-forge Bot added this pull request to stack #920 November 19, 2026 05:46
@fts-forge fts-forge Bot changed the title land/05 web guest views feat(web): NOTE_OPEN for a view, no member controls for a guest, gzipped island files Nov 19, 2026
@fts-forge
fts-forge Bot marked this pull request as ready for review November 19, 2026 05:47
fts-forge Bot added 4 commits November 18, 2026 21:52
…_OPEN)

A frame's asks were the playhead's seven. A set's playlist has rows that
name their songs' notes and no way to go to one. NOTE_OPEN {path} is the
press the viewer would make in the app's own list: the page showing notes
opens it only where the viewer may (a share link's guest: a note the link
lists) and the ask is refused otherwise. It reads nothing.

A note opened on a link starts from its top: the page before it may have
been scrolled far down the list of the link's notes (#910).

(cherry picked from commit 81ac0a4)
…t or a write

A link is this app opened as a guest; what a guest cannot do is a
permission (guide/shares.md). The shell's own controls now say what they
need (crate::permits: nothing, a vault, a write) and are drawn by what
the viewer has: for a guest no Files, Open…, New note, Vault or Search,
and no navigator drawer; Commands, Settings and the player are
everyone's. The same shell and the same views: signed in, they are
back. A link named for its root note draws that title once (#910).

Seen at 390 px on a setlist's link: the two rows of member controls are
gone, the list has their 85 px.

(cherry picked from commit 9374477)
…wn files and those of notes it lists

A share link's first load on a phone (#908, #602): the node sent an
island's files as they are (Studio's web bundle is 8.0 MB of wasm, 3.7 MB
gzipped). A script, module, sheet or wasm under /_ext/ is now sent
gzipped to a browser that takes it, compressed once (each path is named
by its content).

A view on a note was handed the note's own images and lyrics, then every
other file of the link up to the caps, so opening one song fetched every
other song's cover. It is handed its own, then those of the notes it
lists (a setlist's songs): a song gets its own only.

(cherry picked from commit a4f480d)
@fts-forge
fts-forge Bot force-pushed the land/05-web-guest-views branch from 147a7d1 to d170f8d Compare November 19, 2026 06:01
@fts-forge
fts-forge Bot merged commit a3d1bdc into main Nov 19, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants