Repository navigation
feat(session): read the song's structure through the service, ramps included - #184
Merged
Merged
Conversation
…ncluded `Request::ReadStructure` answers the tempo map, markers and regions, a `read` every extension may make: a follower (Ignition's cue list, a chart) resolves musical time with it, so it must see the session's own tempo map, not a copy. `TempoChange` gains the ramp's `shape` and `tension`, so seconds resolve exactly as the session's map does; `TempoMapData::of` and `to_tempo_map` convert. `SessionDoc` gains `markers()` and `regions()`. Test: a linear ramp set with the structure grant reads back unchanged by an extension with none, and resolves seconds to the same quarter notes as the session's map. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
§9 now records steps 1-5 as built (the vox service, the extension face, Keyflow's host, the shared clock with its measured results, the structure read and Ignition's cues), what each found, and what is still missing in order. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For step 5: Ignition places and follows cues in musical time, so it must read the session's own tempo map through
fts.session. Stacked on #183.What it adds
Request::ReadStructureanswers the tempo map, markers and regions. It's aread, which every extension may make, with no grant needed.TempoChangegains the ramp'sshapeandtension. Without them a follower would resolve a ramp as steps, and fire cues at the wrong second.TempoMapData::ofandto_tempo_mapconvert.SessionDocgainsmarkers()andregions().Test
everyone_reads_the_structure_with_its_ramps:Checked
In the fleet shell: fmt, clippy with warnings denied for each feature set, 46 tests, wasm32.
🤖 Generated with Claude Code