Skip to content

feat(session): read the song's structure through the service, ramps included - #184

Merged
fts-forge[bot] merged 3 commits into
mainfrom
feat/structure-read
Nov 18, 2026
Merged

fts-forge[bot] merged 3 commits into
mainfrom
feat/structure-read

Conversation

@fts-forge

@fts-forge fts-forge Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

For step 5: Ignition places and follows cues in musical time, so it must read the session's own tempo map through fts.session. Stacked on #183.

What it adds

  • Request::ReadStructure answers the tempo map, markers and regions. It's a read, which every extension may make, with no grant needed.
  • TempoChange gains the ramp's shape and tension. Without them a follower would resolve a ramp as steps, and fire cues at the wrong second. TempoMapData::of and to_tempo_map convert.
  • SessionDoc gains markers() and regions().

Test

everyone_reads_the_structure_with_its_ramps:

  • a 60→120 BPM linear ramp, set with the structure grant, reads back unchanged by an extension with no grant;
  • it resolves seconds to the same quarter notes as the session's map.

Checked

In the fleet shell: fmt, clippy with warnings denied for each feature set, 46 tests, wasm32.

🤖 Generated with Claude Code

fts-forge Bot and others added 3 commits November 17, 2026 18:25
…ncluded

`Request::ReadStructure` answers the tempo map, markers and regions, a
`read` every extension may make: a follower (Ignition's cue list, a
chart) resolves musical time with it, so it must see the session's own
tempo map, not a copy. `TempoChange` gains the ramp's `shape` and
`tension`, so seconds resolve exactly as the session's map does;
`TempoMapData::of` and `to_tempo_map` convert. `SessionDoc` gains
`markers()` and `regions()`.

Test: a linear ramp set with the structure grant reads back unchanged
by an extension with none, and resolves seconds to the same quarter
notes as the session's map.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
§9 now records steps 1-5 as built (the vox service, the extension face,
Keyflow's host, the shared clock with its measured results, the structure
read and Ignition's cues), what each found, and what is still missing in
order.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fts-forge
fts-forge Bot marked this pull request as ready for review November 18, 2026 03:31
@fts-forge
fts-forge Bot changed the base branch from feat/shared-clock to main November 18, 2026 03:32
@fts-forge
fts-forge Bot merged commit f15c8b8 into main Nov 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants