Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow @JsonAnySetter on Creator constructors #4366

Closed
wants to merge 72 commits into from
Closed

Allow @JsonAnySetter on Creator constructors #4366

wants to merge 72 commits into from

Commits on Jan 27, 2024

  1. temporarily remove other jdk versions

    @JooHyukKim
    JooHyukKim committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    94540f8 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2024

  1. Merge branch '2.17' into 562-jsonanysetter-test

    @JooHyukKim
    JooHyukKim committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    9c6cace View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2024

  1. Working solution first draft

    @JooHyukKim
    JooHyukKim committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    1faccf0 View commit details
    Browse the repository at this point in the history

  2. Revert "temporarily remove other jdk versions" 

    This reverts commit 94540f8.
    @JooHyukKim
    JooHyukKim committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    8930a4e View commit details
    Browse the repository at this point in the history

  3. Delete JsonAnySetterThroughCreator562Test.java

    @JooHyukKim
    JooHyukKim committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    5280004 View commit details
    Browse the repository at this point in the history

  4. Remove hard coded field names

    @JooHyukKim
    JooHyukKim committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    99a882b View commit details
    Browse the repository at this point in the history

  5. Clean Up

    @JooHyukKim
    JooHyukKim committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    a840e56 View commit details
    Browse the repository at this point in the history

  6. Clean up unused _anySetter

    @JooHyukKim
    JooHyukKim committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    75c23f1 View commit details
    Browse the repository at this point in the history

  7. Add back required property _anySetter implementation

    @JooHyukKim
    JooHyukKim committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    2b7d22f View commit details
    Browse the repository at this point in the history

  8. Merge branch '2.17' into 562-jsonanysetter-test

    @JooHyukKim
    JooHyukKim authored Feb 3, 2024
    Configuration menu
    Copy the full SHA
    2f49175 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2024

  1. Add Boolean _ hasAnySetter in

    @JooHyukKim
    JooHyukKim committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    1a9afab View commit details
    Browse the repository at this point in the history

  2. Use hasAnySetter from CreatorProperty

    @JooHyukKim
    JooHyukKim committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    2b2e0aa View commit details
    Browse the repository at this point in the history

  3. Remove unncessary anySetter construction

    @JooHyukKim
    JooHyukKim committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    6a892f8 View commit details
    Browse the repository at this point in the history

  4. Revert "Remove unncessary anySetter construction" 

    This reverts commit 6a892f8.
    @JooHyukKim
    JooHyukKim committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    765ed3a View commit details
    Browse the repository at this point in the history

  5. Put back isAnySetterXxx methods and fields

    @JooHyukKim
    JooHyukKim committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    57d467a View commit details
    Browse the repository at this point in the history

  6. Fix JDK 8 error

    @JooHyukKim
    JooHyukKim committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    2ae2dca View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Merge branch '2.17' into 562-jsonanysetter-test

    @JooHyukKim
    JooHyukKim committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    c4657cc View commit details
    Browse the repository at this point in the history

  2. Move test dir

    @JooHyukKim
    JooHyukKim committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    7da980a View commit details
    Browse the repository at this point in the history

  3. Fix error

    @JooHyukKim
    JooHyukKim committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    09d4c82 View commit details
    Browse the repository at this point in the history

  4. Add new SettableAnyProperty impl

    @JooHyukKim
    JooHyukKim committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    9baad77 View commit details
    Browse the repository at this point in the history

  5. Remove hard coded prop name

    @JooHyukKim
    JooHyukKim committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    81a8803 View commit details
    Browse the repository at this point in the history

  6. Update javadoc and clean comments

    @JooHyukKim
    JooHyukKim committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    742a589 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2024

  1. Merge branch '2.17' into 562-jsonanysetter-test

    @cowtowncoder
    cowtowncoder authored Feb 10, 2024
    Configuration menu
    Copy the full SHA
    19182fa View commit details
    Browse the repository at this point in the history

  2. Minor clean up, streamlining

    @cowtowncoder
    cowtowncoder committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    010849a View commit details
    Browse the repository at this point in the history

  3. Add verification there's only one any-setter

    @cowtowncoder
    cowtowncoder committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    10540a8 View commit details
    Browse the repository at this point in the history

  4. Test case for disabled(@JsonAnySetter) (rain check?

    @JooHyukKim
    JooHyukKim committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    1458882 View commit details
    Browse the repository at this point in the history

  5. Require non-null _valueInstantiator during construction

    @JooHyukKim
    JooHyukKim committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    bddb042 View commit details
    Browse the repository at this point in the history

  6. Add test with DeserializationFeature.FAIL_ON_NULL_CREATOR_PROPERTIES

    @JooHyukKim
    JooHyukKim committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    5c1f30d View commit details
    Browse the repository at this point in the history

  7. Fix tests

    @JooHyukKim
    JooHyukKim committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    bdc2357 View commit details
    Browse the repository at this point in the history

  8. Update AnySetterForCreator562Test.java

    @JooHyukKim
    JooHyukKim committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    47ac3f7 View commit details
    Browse the repository at this point in the history

  9. Implement version 2 

    Add quick check before iteration start
    @JooHyukKim
    JooHyukKim committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    8612433 View commit details
    Browse the repository at this point in the history

  10. Clean up changes

    @JooHyukKim
    JooHyukKim committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    5d69465 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Merge branch '2.17' into 562-jsonanysetter-test

    @JooHyukKim
    JooHyukKim authored Feb 12, 2024
    Configuration menu
    Copy the full SHA
    551a001 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Merge branch '2.17' into 562-jsonanysetter-test

    @cowtowncoder
    cowtowncoder authored Feb 19, 2024
    Configuration menu
    Copy the full SHA
    7d7a4c5 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Merge branch '2.17' into 562-jsonanysetter-test

    @JooHyukKim
    JooHyukKim authored Apr 8, 2024
    Configuration menu
    Copy the full SHA
    778ddc3 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Merge branch '2.17' into 562-jsonanysetter-test

    @cowtowncoder
    cowtowncoder authored May 31, 2024
    Configuration menu
    Copy the full SHA
    30c0f57 View commit details
    Browse the repository at this point in the history

  2. temporarily remove other jdk versions

    @JooHyukKim
    JooHyukKim committed May 31, 2024
    Configuration menu
    Copy the full SHA
    7a55942 View commit details
    Browse the repository at this point in the history

  3. Working solution first draft

    @JooHyukKim
    JooHyukKim committed May 31, 2024
    Configuration menu
    Copy the full SHA
    ff22500 View commit details
    Browse the repository at this point in the history

  4. Revert "temporarily remove other jdk versions" 

    This reverts commit 94540f8.
    @JooHyukKim
    JooHyukKim committed May 31, 2024
    Configuration menu
    Copy the full SHA
    e2670e6 View commit details
    Browse the repository at this point in the history

  5. Delete JsonAnySetterThroughCreator562Test.java

    @JooHyukKim
    JooHyukKim committed May 31, 2024
    Configuration menu
    Copy the full SHA
    05a4c0b View commit details
    Browse the repository at this point in the history

  6. Remove hard coded field names

    @JooHyukKim
    JooHyukKim committed May 31, 2024
    Configuration menu
    Copy the full SHA
    dd53092 View commit details
    Browse the repository at this point in the history

  7. Clean Up

    @JooHyukKim
    JooHyukKim committed May 31, 2024
    Configuration menu
    Copy the full SHA
    49f8b95 View commit details
    Browse the repository at this point in the history

  8. Clean up unused _anySetter

    @JooHyukKim
    JooHyukKim committed May 31, 2024
    Configuration menu
    Copy the full SHA
    b4d03e3 View commit details
    Browse the repository at this point in the history

  9. Add back required property _anySetter implementation

    @JooHyukKim
    JooHyukKim committed May 31, 2024
    Configuration menu
    Copy the full SHA
    426f303 View commit details
    Browse the repository at this point in the history

  10. Add Boolean _ hasAnySetter in

    @JooHyukKim
    JooHyukKim committed May 31, 2024
    Configuration menu
    Copy the full SHA
    201c5ea View commit details
    Browse the repository at this point in the history

  11. Use hasAnySetter from CreatorProperty

    @JooHyukKim
    JooHyukKim committed May 31, 2024
    Configuration menu
    Copy the full SHA
    a247d02 View commit details
    Browse the repository at this point in the history

  12. Remove unncessary anySetter construction

    @JooHyukKim
    JooHyukKim committed May 31, 2024
    Configuration menu
    Copy the full SHA
    2ece9f9 View commit details
    Browse the repository at this point in the history

  13. Revert "Remove unncessary anySetter construction" 

    This reverts commit 6a892f8.
    @JooHyukKim
    JooHyukKim committed May 31, 2024
    Configuration menu
    Copy the full SHA
    d3d8546 View commit details
    Browse the repository at this point in the history

  14. Put back isAnySetterXxx methods and fields

    @JooHyukKim
    JooHyukKim committed May 31, 2024
    Configuration menu
    Copy the full SHA
    3d632f4 View commit details
    Browse the repository at this point in the history

  15. Fix JDK 8 error

    @JooHyukKim
    JooHyukKim committed May 31, 2024
    Configuration menu
    Copy the full SHA
    ce58b14 View commit details
    Browse the repository at this point in the history

  16. Move test dir

    @JooHyukKim
    JooHyukKim committed May 31, 2024
    Configuration menu
    Copy the full SHA
    21a0795 View commit details
    Browse the repository at this point in the history

  17. Fix error

    @JooHyukKim
    JooHyukKim committed May 31, 2024
    Configuration menu
    Copy the full SHA
    09296d1 View commit details
    Browse the repository at this point in the history

  18. Add new SettableAnyProperty impl

    @JooHyukKim
    JooHyukKim committed May 31, 2024
    Configuration menu
    Copy the full SHA
    3445ddd View commit details
    Browse the repository at this point in the history

  19. Remove hard coded prop name

    @JooHyukKim
    JooHyukKim committed May 31, 2024
    Configuration menu
    Copy the full SHA
    9e95155 View commit details
    Browse the repository at this point in the history

  20. Update javadoc and clean comments

    @JooHyukKim
    JooHyukKim committed May 31, 2024
    Configuration menu
    Copy the full SHA
    1908532 View commit details
    Browse the repository at this point in the history

  21. Minor clean up, streamlining

    @cowtowncoder @JooHyukKim
    cowtowncoder authored and JooHyukKim committed May 31, 2024
    Configuration menu
    Copy the full SHA
    659bbf2 View commit details
    Browse the repository at this point in the history

  22. Add verification there's only one any-setter

    @cowtowncoder @JooHyukKim
    cowtowncoder authored and JooHyukKim committed May 31, 2024
    Configuration menu
    Copy the full SHA
    fcfac63 View commit details
    Browse the repository at this point in the history

  23. Test case for disabled(@JsonAnySetter) (rain check?

    @JooHyukKim
    JooHyukKim committed May 31, 2024
    Configuration menu
    Copy the full SHA
    f6a6c37 View commit details
    Browse the repository at this point in the history

  24. Require non-null _valueInstantiator during construction

    @JooHyukKim
    JooHyukKim committed May 31, 2024
    Configuration menu
    Copy the full SHA
    93b8587 View commit details
    Browse the repository at this point in the history

  25. Add test with DeserializationFeature.FAIL_ON_NULL_CREATOR_PROPERTIES

    @JooHyukKim
    JooHyukKim committed May 31, 2024
    Configuration menu
    Copy the full SHA
    134d8d1 View commit details
    Browse the repository at this point in the history

  26. Fix tests

    @JooHyukKim
    JooHyukKim committed May 31, 2024
    Configuration menu
    Copy the full SHA
    7c60905 View commit details
    Browse the repository at this point in the history

  27. Update AnySetterForCreator562Test.java

    @JooHyukKim
    JooHyukKim committed May 31, 2024
    Configuration menu
    Copy the full SHA
    3e62a2b View commit details
    Browse the repository at this point in the history

  28. Implement version 2 

    Add quick check before iteration start
    @JooHyukKim
    JooHyukKim committed May 31, 2024
    Configuration menu
    Copy the full SHA
    60a2933 View commit details
    Browse the repository at this point in the history

  29. Clean up changes

    @JooHyukKim
    JooHyukKim committed May 31, 2024
    Configuration menu
    Copy the full SHA
    40061f9 View commit details
    Browse the repository at this point in the history

  30. Add missing imports

    @JooHyukKim
    JooHyukKim committed May 31, 2024
    Configuration menu
    Copy the full SHA
    cd86a74 View commit details
    Browse the repository at this point in the history

  31. Merge branch '562-jsonanysetter-test' of https://github.com/JooHyukKi… 

    …m/jackson-databind into 562-jsonanysetter-test
    @JooHyukKim
    JooHyukKim committed May 31, 2024
    Configuration menu
    Copy the full SHA
    6cbdeff View commit details
    Browse the repository at this point in the history

  32. Merge branch '2.18' into 562-jsonanysetter-test

    @cowtowncoder
    cowtowncoder committed May 31, 2024
    Configuration menu
    Copy the full SHA
    8046794 View commit details
    Browse the repository at this point in the history

  33. Clean up code, version, etc...

    @JooHyukKim
    JooHyukKim committed May 31, 2024
    Configuration menu
    Copy the full SHA
    2de9beb View commit details
    Browse the repository at this point in the history

  34. Merge branch '2.18' into 562-jsonanysetter-test

    @cowtowncoder
    cowtowncoder committed May 31, 2024
    Configuration menu
    Copy the full SHA
    825f31e View commit details
    Browse the repository at this point in the history

  35. Merge branch '2.18' into 562-jsonanysetter-test

    @cowtowncoder
    cowtowncoder committed May 31, 2024
    Configuration menu
    Copy the full SHA
    cdcdf3e View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2024

  1. Apply review

    @JooHyukKim
    JooHyukKim committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    2cd2b9d View commit details
    Browse the repository at this point in the history

  2. Change initMap() method to createAnyPropertyMap()

    @JooHyukKim
    JooHyukKim committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    b616cb6 View commit details
    Browse the repository at this point in the history