Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SerializerCache: remove synchronization when only _sharedMap is accessed with a read call #4459

Open
wants to merge 2 commits into
base: 2.18
Choose a base branch
from
Open

SerializerCache: remove synchronization when only _sharedMap is accessed with a read call #4459

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7a5e15
remove synchronization when only _sharedMap is access with a read call
pjfanning Mar 28, 2024
c54880e
Merge branch '2.18' into serializercache-read-no-synch
cowtowncoder Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions src/main/java/com/fasterxml/jackson/databind/ser/SerializerCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ private final synchronized ReadOnlyClassToSerializerMap _makeReadOnlyLookupMap()
/**********************************************************
*/

public synchronized int size() {
public int size() {
return _sharedMap.size();
}

Expand All @@ -107,30 +107,22 @@ public synchronized int size() {
*/
public JsonSerializer<Object> untypedValueSerializer(Class<?> type)
{
synchronized (this) {
return _sharedMap.get(new TypeKey(type, false));
}
return _sharedMap.get(new TypeKey(type, false));
}

public JsonSerializer<Object> untypedValueSerializer(JavaType type)
{
synchronized (this) {
return _sharedMap.get(new TypeKey(type, false));
}
return _sharedMap.get(new TypeKey(type, false));
}

public JsonSerializer<Object> typedValueSerializer(JavaType type)
{
synchronized (this) {
return _sharedMap.get(new TypeKey(type, true));
}
return _sharedMap.get(new TypeKey(type, true));
}

public JsonSerializer<Object> typedValueSerializer(Class<?> cls)
{
synchronized (this) {
return _sharedMap.get(new TypeKey(cls, true));
}
return _sharedMap.get(new TypeKey(cls, true));
}

/*
Expand Down