-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix builder forward references resolved within typed arrays #6226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jakezwang
wants to merge
4
commits into
FasterXML:3.2
Choose a base branch
from
jakezwang:fix/builder-array-forward-reference
base: 3.2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+37
−4
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
a1e61ce
Fix builder forward references resolved within typed arrays
jakezwang 5eabfef
Merge branch '3.2' into fix/builder-array-forward-reference
cowtowncoder 81dce17
Document issue and version for array reference rebinding
jakezwang dd05c0c
Merge branch '3.2' into fix/builder-array-forward-reference
cowtowncoder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -420,6 +420,36 @@ public void forwardReferenceInTypedArrayWithBuilder() throws Exception | |
| "forward ref must be rebound from Builder to built object in typed array"); | ||
| } | ||
|
|
||
| // [databind#6225]: rebind a Builder before the typed array is materialized. | ||
| @Test | ||
| public void forwardReferenceResolvedWithinTypedArrayWithBuilder() throws Exception | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When adding to pre existing test class, we courage tests to contain some information about original GitHub issue. |
||
| { | ||
| EntityArray entity = MAPPER.readValue(""" | ||
| {"id":0,"refs":[1,{"id":1}]} | ||
| """, EntityArray.class); | ||
|
|
||
| assertEquals(2, entity.refs.length); | ||
| assertEquals(1, entity.refs[0].id); | ||
| assertSame(entity.refs[1], entity.refs[0]); | ||
| } | ||
|
|
||
| // [databind#6225]: repeated forward references share the final built value. | ||
| @Test | ||
| public void multipleForwardReferencesResolvedWithinTypedArrayWithBuilder() throws Exception | ||
| { | ||
| EntityArray entity = MAPPER.readValue(""" | ||
| {"id":0,"refs":[1,2,1,{"id":2},null,{"id":1}]} | ||
| """, EntityArray.class); | ||
|
|
||
| assertEquals(6, entity.refs.length); | ||
| assertEquals(1, entity.refs[0].id); | ||
| assertEquals(2, entity.refs[1].id); | ||
| assertSame(entity.refs[5], entity.refs[0]); | ||
| assertSame(entity.refs[3], entity.refs[1]); | ||
| assertSame(entity.refs[5], entity.refs[2]); | ||
| assertNull(entity.refs[4]); | ||
| } | ||
|
|
||
| // ---- Delegating-creator variant ([databind#1706] + collection forward | ||
| // refs): the bound id'd instance is a transient delegate (Mutable*) which | ||
| // is replaced via updateObjectId after createUsingDelegate. Forward refs | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.