Fix #384: change handling of SmileBufferRecycler to be thread-safe#385
Merged
cowtowncoder merged 1 commit into2.15from Jun 19, 2023
Merged
Fix #384: change handling of SmileBufferRecycler to be thread-safe#385cowtowncoder merged 1 commit into2.15from
cowtowncoder merged 1 commit into2.15from
Conversation
Member
Author
|
@simondaudin I think this should fix it; will merge but would appreciate if you could verify on your end. Targeting 2.15 branch for eventual 2.15.3 release (and 2.16.0). |
|
@cowtowncoder Thank you for the fix, that was fast !
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify
SmileBufferRecyclerby usingAtomicReferenceto guard access to buffers. This didn't use to be problematic before async handling (when there was typically 1-to-1 matching between threads and Parser/Generator instances).However, this changed for both:
and so there's no guarantee of atomicity for reuse by recycler.