Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for StreamWriteConstraints checks #386

Merged
merged 9 commits into from
Jul 12, 2023

Conversation

pjfanning
Copy link
Member

@cowtowncoder cowtowncoder changed the title police against cyclic data Add support for StreamWriteConstraints checks Jul 12, 2023
@cowtowncoder cowtowncoder merged commit cdd70bb into FasterXML:2.16 Jul 12, 2023
3 checks passed
@pjfanning pjfanning deleted the cyclic-data branch July 12, 2023 22:13
cowtowncoder added a commit that referenced this pull request Jul 12, 2023
@cowtowncoder
Copy link
Member

Phew. Managed to merge to master.

One quick note: limits will not work with Avro serialization as of now -- problem is that we construct Avro's internal objects using separate stack. If anyone has time and interest, this is solvable; just need to add checks in bit different places.

I'll actually create a new issue for this flaw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants