getColumnDesc returns unpaired square bracket when columns are empty (#…

…283)
FasterXML · Aug 24, 2021 · d930a12 · d930a12
1 parent 3a30855
commit d930a12
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/csv/src/main/java/com/fasterxml/jackson/dataformat/csv/CsvSchema.java b/csv/src/main/java/com/fasterxml/jackson/dataformat/csv/CsvSchema.java
@@ -1456,10 +1456,9 @@ public Column column(String name, int probableIndex) {
     public String getColumnDesc()
     {
         StringBuilder sb = new StringBuilder(100);
+        sb.append('[');
         for (Column col : _columns) {
-            if (sb.length() == 0) {
-                sb.append('[');
-            } else {
+            if (sb.length() > 1) {
                 sb.append(',');
             }
             sb.append('"');

diff --git a/csv/src/test/java/com/fasterxml/jackson/dataformat/csv/schema/CsvSchemaTest.java b/csv/src/test/java/com/fasterxml/jackson/dataformat/csv/schema/CsvSchemaTest.java
@@ -142,6 +142,12 @@ public void testReorderWithComparator() throws Exception
         _verifyLinks(schema);
     }
 
+    public void testColumnDescForEmptyScheme() throws Exception
+    {
+        CsvSchema schema = CsvSchema.emptySchema();
+        assertEquals("[]", schema.getColumnDesc());
+    }
+
     private void _verifyLinks(CsvSchema schema)
     {
         List<Column> all = new ArrayList<Column>();