Add Hibernate 7 module#185
Conversation
| if (_mapping != null) { | ||
| idName = _mapping.getIdentifierPropertyName(init.getEntityName()); | ||
| } else { | ||
| // no unit tests rely on this next call and Hibernate 7 does not support it |
There was a problem hiding this comment.
Is this change related to Hibernate 7 addition? If not (and I suspect it isn't), could we have separate PR to merge this change in first?
|
@pjfanning Looks good overall (although TBH can't really review much of Hibernate 7 module itself). I merged small parts of But one thing, as per my comment: looks like there are unrelated Hibernate 6 changes (fixes I presume): if so, would it make sense to merge them in via separate PR, before main change of adding Hibernate 7 module? |
cowtowncoder
left a comment
cowtowncoder
left a comment
There was a problem hiding this comment.
LGTM: ideally would separate H6 changes to separate PR but that's just tactical change.
| { | ||
| protected BaseTest() { | ||
| try { | ||
| System.out.println(Hibernate7Version.isHibernate7_Plus()); |
There was a problem hiding this comment.
Oh, missed this one: should probably be removed, or (if useful) add bit more context.
There was a problem hiding this comment.
- removed the println but kept the log stmt
- this code is mainly a copy/paste of the hibernate6 module with some changes to account for API changes
- the BaseTest is basically unmodified
There was a problem hiding this comment.
Ah. Did not realize -- will remove println's from other modules' BaseTests too.
2 participants
Implements #184 adding
jackson-datatype-hibernate7module.