Try to fix #160 (OSGi dep problem wrt Guava) #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpstotz
reviewed
Sep 10, 2024
guava/pom.xml
Outdated
|
|
||
| <javac.src.version>1.8</javac.src.version> | ||
| <javac.target.version>1.8</javac.target.version> | ||
|
|
||
| <!-- 31-Jul-2020, tatu: remove upper limit for Jackson 2.12; tested up to 30.x --> | ||
| <version.guava.osgi>[${version.guava}.0,99)</version.guava.osgi> | ||
| <version.guava.osgi>[${version.guava.osgi-base}, 99)</version.guava.osgi> |
There was a problem hiding this comment.
A space has been added before 99- I am not sure if this is allowed in an OSGi version range selector. I would recommend to omit the space.
There was a problem hiding this comment.
Thanks, that was unintentional -- I suspect it should be ok but better safe than sorry so will remove
jpstotz
reviewed
Sep 10, 2024
guava/pom.xml
Outdated
| @@ -38,12 +38,13 @@ Guava (https://github.com/google/guava) types (currently mostly just collection | |||
| <!-- 28-Feb-2023, tatu: 2.15 raises baseline from 21.x to 23.x --> | |||
| <!-- 01-May-2023, tatu: 2.16 raises baseline from 23.x to 25.x --> | |||
| <version.guava>25.1-jre</version.guava> | |||
| <version.guava.osgi-base>25.1</version.guava.osgi-base> | |||
There was a problem hiding this comment.
As mentioned in #160 (comment) the exact version that is used for exporting the required package in guava library is 25.1.0. Thus using this exact version string we should be safe.
|
@jpstotz Better now? I realize testing this is difficult. |
|
@cowtowncoder Thanks. Thank way it should work. |
|
Ok let's just try it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defining OSGi min base version bit differently (as 25.1); hopefully this works.