-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Jakarta EE 9 #95
Conversation
Ok, one quick request: could you also create issue with above description, to refer this PR from? I will have to think about this: I agree that it is a big jump and has to be coordinated. One question on compatibility: does this change JDK baseline requirement (I don't think so, based on changes)? For 3.0 Java 8 is needed. One other approach here would be to create separate new JAXB module; this would have the benefit of users being able to use old or new one. If we were to introduce this in 2.x that would probably be necessary. With 3.0, maybe less so. @GedMarc wdyt? |
For version 3, I think this is definitely mandatory to go to Jakarta 9.
Java SE Version For inclusion in Jakarta EE 9, specification’s APIs MUST be compiled at the Java SE 8 source level. However, compatible implementations of the Jakarta EE 9 Web Profile and Full Profile MUST certify compatibility on Java SE 11. Compatible Implementations MAY additionally certify and support Java SE 8. References - Jakarta 9 Spec (https://eclipse-ee4j.github.io/jakartaee-platform/jakartaee9/JakartaEE9ReleasePlan )
Just my 2 cents worth - |
Done: #96
If you are referring to all the other packages in the Jackson suite, I can provide PRs for them too. But obviously as you said it's a massive move and need proper coordination. |
I think the only repos affected would be this (for JAXB annotations module), I really do not know if, when and how to proceed here: I do not see this happening in near term, esp. without users requesting it. |
This is still going to be a while off - M4 just released with 3 more to go, i also see that servlet 5 has a new module name/namespace (relating to jax-rs) Hibernate module (which may be dropped if I remember right) has a reliance on jaxb as well, |
Theoretically may even be necessary to create separate repos and modules here :-/ |
I think #116 resolved this? |
Note for anyone finding this via search engines etc: for Jackson 2.13, the relevant change is #130: addition of a separate module -- so the existing, "old" module will support old javax/JAXB annotations, and new one Jakarta XML Bind annotations. |
Jakarta EE 9 platform renames all the "old" namespaces from javax.* to jakarta.*. This pull request performs this migration so that when Jacakrta EE 9 is released in June 2020 it will be compatible.
I ran mvn test with no* failures and travis builds did not fail.
Note 1: this is completely incompatible with the old namespace, so probably the major version of the library should be bumped.
Note 2: currently depends on pre-released versions of the JAXB specification (RC3). This can be updated when the final version is released.
*: a couple of the afterburner tests failed, but I haven't modified that module and I'm not exactly sure how to debug that.