Year key deser fix #134
Merged
Year key deser fix #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from the other tests.
|
Excellent, adding this to my TODO list to get in 2.10 after verifying. Not sure if I should be concerned about strict/lenient handling, but that's about all. |
|
Going forward, it'd be great if these could be done against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is @ sladkoff's proposal to fix YearKeyDeserializer so it can deserialize keys that are not in the format yyyy , i.e. the the year does not need to be padded with zeros ("0001") but could instead be "1". See issue #51