Add Ferrite.write_facetset #1259
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1259 +/- ##
=======================================
Coverage 94.19% 94.19%
=======================================
Files 40 40
Lines 6662 6671 +9
=======================================
+ Hits 6275 6284 +9
Misses 387 387 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KnutAM
reviewed
Dec 14, 2025
| end | ||
|
|
||
| """ | ||
| write_facetset(vtk::VTKGridFile, grid::AbstractGrid, facetset::String) |
Member
There was a problem hiding this comment.
Would be nice to match the interface from cellsets allowing a vector/set of keys?
Also, since this is not as trivial as cellsets, perhaps it could even be nice to have a lower-level interface providing just an AbstractVecOrSet{<:FacetIndex}, not requiring it to be stored in the grid?
KnutAM
reviewed
Dec 14, 2025
| function write_facetset(vtk, grid::AbstractGrid, facetset::String) | ||
| z = zeros(getnnodes(grid)) | ||
| for fi in getfacetset(grid, facetset) | ||
| for i in facets(getcells(grid, fi[1]))[fi[2]] |
Member
There was a problem hiding this comment.
To make work for higher order elements, I think this is required.
Suggested change
| for i in facets(getcells(grid, fi[1]))[fi[2]] | |
| cell = getcells(grid, fi[1] | |
| for cellnode in facetdof_indices(geometric_interpolation(cell))[fi[2]] | |
| i = get_node_ids(cell)[cellnode] |
Member
|
Btw will (or can) this close #192, or is that already resolved? |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.