Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following Hooking into the Random API I replaced the
Base.rand(Type{<:AbstractTensor})
byBase.rand(rng::AbstractRNG, ::SamplerType{<:AbstractTensor})
, which has the advantage of supportingrand(MersenneTwister(1), Tensor{2,3})
rand!(::Array{<:AbstractTensor})
.rand(Vec{2}, 2)
(However, specific overload is added to get, e.g.Vector{Vec{2,Float64}}
in this case instead ofVector{Vec{2}}
.)rand(MersenneTwister(2), Vec{2}, 2)
AFAIU the same API doesn't work for
randn
, so this is kept as is.Julia 1.6: For some reason, the type for
apply_all
withf(i) = rand(rng, T)
(whereT<:Number
) is not typestable on julia 1.6, but works at least on 1.8 and later. Old implementation is therefore kept to have fast performance for e.g.rand(Tensor{2,3})
, but the new functionality in the list above is slow (but typestable output via typeassert) on julia 1.6.