fix: expose getScheduledRemovals on storageContext #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR exposes the getScheduledRemovals method on the StorageContext class, providing a convenience method for users to retrieve pieces scheduled for removal without needing to instantiate a PDPVerifier directly.
- Added
getScheduledRemovals()method toStorageContextclass that wrapsPDPVerifier.getScheduledRemovals() - Included test coverage for the happy path and edge case (no data set configured)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/synapse-sdk/src/storage/context.ts |
Implements the new getScheduledRemovals() method that creates a PDPVerifier instance internally and delegates to its getScheduledRemovals() method, with proper error handling |
packages/synapse-sdk/src/test/storage.test.ts |
Adds test suite covering successful retrieval and empty array return when no data set is configured |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
synapse-dev | fd2980c | Commit Preview URL Branch Preview URL |
Dec 11 2025, 05:46 PM |
rvagg
approved these changes
Dec 8, 2025
github-project-automation
bot
moved this from ⌚️ Issue awaiting PR merge
to 🎉 Done
in FS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds
getScheduledRemovalsto the StorageContext class so users don't have to instantiate a PDPVerifier themselves.Related filecoin-project/filecoin-pin#253 (comment)