feat!: use activePieceCount for accurate piece tracking #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING: EnhancedDataSetInfo.nextPieceId removed, s/currentPieceCount/activePieceCount This exposes getActivePieceCount from PDPVerifier, replaces the inaccurate nextPieceId-based counting with actual active piece count, and removes nextPieceId from the data set details struct to avoid extra eth_call for a low- value piece of information.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
synapse-dev | a1ac567 | Dec 18 2025, 06:58 AM |
SgtPooki
approved these changes
Dec 18, 2025
Contributor
SgtPooki
left a comment
SgtPooki
left a comment
There was a problem hiding this comment.
changes look good to me.. pretty straightforward
github-project-automation
bot
moved this from 🔎 Awaiting review
to ✔️ Approved by reviewer
in FOC
SgtPooki
pushed a commit
that referenced
this pull request
Jan 5, 2026
BREAKING: EnhancedDataSetInfo.nextPieceId removed, s/currentPieceCount/activePieceCount This exposes getActivePieceCount from PDPVerifier, replaces the inaccurate nextPieceId-based counting with actual active piece count, and removes nextPieceId from the data set details struct to avoid extra eth_call for a low- value piece of information.
SgtPooki
pushed a commit
that referenced
this pull request
Jan 5, 2026
BREAKING: EnhancedDataSetInfo.nextPieceId removed, s/currentPieceCount/activePieceCount This exposes getActivePieceCount from PDPVerifier, replaces the inaccurate nextPieceId-based counting with actual active piece count, and removes nextPieceId from the data set details struct to avoid extra eth_call for a low- value piece of information.
SgtPooki
pushed a commit
that referenced
this pull request
Jan 5, 2026
BREAKING: EnhancedDataSetInfo.nextPieceId removed, s/currentPieceCount/activePieceCount This exposes getActivePieceCount from PDPVerifier, replaces the inaccurate nextPieceId-based counting with actual active piece count, and removes nextPieceId from the data set details struct to avoid extra eth_call for a low- value piece of information.
This was referenced Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING: EnhancedDataSetInfo.nextPieceId removed,
s/currentPieceCount/activePieceCountThis exposes getActivePieceCount from PDPVerifier, replaces the inaccurate nextPieceId-based counting with actual active piece count, and removes nextPieceId from the data set details struct to avoid extra eth_call for a low- value piece of information.
This is a fix on top of #487, I think it should probably be landed separately because of the breaking change. Happy to discuss that breakage though.
nextPieceIdwas originally interesting because it was used as the nonce for AddPieces, but now it's just left as a proxy for piece count, but even that's not accurate because of removals, and we've since addedgetActivePieceCountthat we can call directly. It iterates over the pieces, but this is an eth_call so it's not going to be measurably slower thangetNextPieceIdwhere we need it.