Skip to content

Conversation

@Kroustille
Copy link
Member

Context

Briefly describe the purpose and context of this PR. Include relevant screenshots or screen recordings for the product team.

Connectors uses another URL for 1 click deploy than CSV Feeds, even if they are both integration feeds.
This PR adds the 1 click deploy button on connector detail page, with the right URL configuration.

How to test

Provide step-by-step instructions to test your changes. Include screenshots of your local testing results.

Related issues

Checklist

Quality

  • I consider this work complete and ready for review
  • I tested all features and edge cases
  • I refactored code where necessary to improve quality
  • I made sure my code meets development guidelines
  • I performed a self-review of my code

Testing

  • I wrote test cases for the relevant use cases (unit, integration or e2e tests)
  • (Bug fixes only) I added tests that reproduce and verify the fix

What tests have been made

  • Unit tests
  • Integration tests
  • E2E tests
  • Local manual tests

Additional information

Any additional context, dependencies, or concerns reviewers should know about.

@github-actions github-actions bot added the Filigran Team use to identify PR from the Filigran team label Oct 27, 2025
@Kroustille Kroustille added the needs feature env Indicate if the PR needs an associated feature environment label Oct 27, 2025
@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

❌ Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.05%. Comparing base (41d210f) to head (6fba820).

Files with missing lines Patch % Lines
...nt/connector/shareable-resource-connector-slug.tsx 0.00% 5 Missing ⚠️
...document/one-click-deploy/useOneClickDeployTab.tsx 0.00% 3 Missing ⚠️
...p/(public)/cybersecurity-solutions/[slug]/page.tsx 0.00% 1 Missing ⚠️
...eds/[serviceInstanceId]/integration-feeds-list.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1182      +/-   ##
===============================================
- Coverage        24.05%   24.05%   -0.01%     
===============================================
  Files              542      542              
  Lines            32490    32498       +8     
  Branches          1403     1403              
===============================================
  Hits              7816     7816              
- Misses           24433    24441       +8     
  Partials           241      241              
Files with missing lines Coverage Δ
apps/portal-front/src/utils/constant.ts 100.00% <100.00%> (ø)
...p/(public)/cybersecurity-solutions/[slug]/page.tsx 0.00% <0.00%> (ø)
...eds/[serviceInstanceId]/integration-feeds-list.tsx 0.00% <0.00%> (ø)
...document/one-click-deploy/useOneClickDeployTab.tsx 0.00% <0.00%> (ø)
...nt/connector/shareable-resource-connector-slug.tsx 1.49% <0.00%> (-0.13%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41d210f...6fba820. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2025

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
22 22 0 0 0 0 2m 18s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
22 0 0 23.9s

Suites

22 passed, 0 failed, and 0 other

Suite Passed Failed Other Duration
✅ app/apps/portal-e2e-tests/tests/tests_files/api/user.spec.ts
        ✅ should prevent user to update another one when he does not have MANAGE_ACCESS
        ✅ should allow user to update another one when he has ADMINISTRATE_ORGANIZATION
        ✅ should allow user to update another one when he has MANAGE_ACCESS
✅ 3 ❌ 0 ⏭️ 0 4.7s
✅ app/apps/portal-e2e-tests/tests/tests_files/capabilities.spec.ts
        ✅ Should add subscription with capabilities
✅ 1 ❌ 0 ⏭️ 0 23.9s
✅ app/apps/portal-e2e-tests/tests/tests_files/csv-feeds.spec.ts
        ✅ Should add CSV Feed
        ✅ Should delete CSV Feed from the list
        ✅ Should delete CSV Feed from the detailed page
✅ 3 ❌ 0 ⏭️ 0 23.0s
✅ app/apps/portal-e2e-tests/tests/tests_files/custom-dashboards.spec.ts
        ✅ Should add custom dashboard
        ✅ Should see the custom dashboard on public page
        ✅ Should edit a custom dashboard
✅ 3 ❌ 0 ⏭️ 0 26.4s
✅ app/apps/portal-e2e-tests/tests/tests_files/document.spec.ts
        ✅ should perform complete CRUD operations on documents
✅ 1 ❌ 0 ⏭️ 0 4.6s
✅ app/apps/portal-e2e-tests/tests/tests_files/one-click-deploy.spec.ts
        ✅ should send telemetry event
✅ 1 ❌ 0 ⏭️ 0 5.4s
✅ app/apps/portal-e2e-tests/tests/tests_files/organizations.spec.ts
        ✅ should perform complete CRUD operations on organizations
✅ 1 ❌ 0 ⏭️ 0 5.4s
✅ app/apps/portal-e2e-tests/tests/tests_files/profile.spec.ts
        ✅ should update user profile information
✅ 1 ❌ 0 ⏭️ 0 4.7s
✅ app/apps/portal-e2e-tests/tests/tests_files/public/redirections.spec.ts
        ✅ should redirect user between public pages and login page
✅ 1 ❌ 0 ⏭️ 0 3.0s
✅ app/apps/portal-e2e-tests/tests/tests_files/registration.spec.ts
        ✅ should register openAEV platform
        ✅ should register openCTI platform
✅ 2 ❌ 0 ⏭️ 0 6.0s
✅ app/apps/portal-e2e-tests/tests/tests_files/service-management.spec.ts
        ✅ should be able to admin service
✅ 1 ❌ 0 ⏭️ 0 9.5s
✅ app/apps/portal-e2e-tests/tests/tests_files/service-pictures.spec.ts
        ✅ should be able to add pictures to a service
✅ 1 ❌ 0 ⏭️ 0 4.1s
✅ app/apps/portal-e2e-tests/tests/tests_files/user.spec.ts
        ✅ Should perform complete CRUD of users as BYPASS
        ✅ Should only see authorized users
        ✅ Should not edit first and last name as MANAGE_ACCESS user
✅ 3 ❌ 0 ⏭️ 0 16.7s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@Kroustille Kroustille force-pushed the issue/1065 branch 3 times, most recently from 51cd479 to 5147c04 Compare October 30, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Filigran Team use to identify PR from the Filigran team needs feature env Indicate if the PR needs an associated feature environment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants